set Location of menu wrt Display coordinate system #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contributes to scaling of the point used to set location of a menu bar in a display coordinate space hence the scaling methods used for such Points must be the ones used for Display coordinate system. contributes to eclipse-platform#62 and eclipse-platform#127
HeikoKlare
force-pushed
the
fix_menu_set_location_wrt_display_coordinate_system
branch
from
b908e03 to
85a4aed
Compare
fedejeanne
approved these changes
Oct 15, 2024
|
Failing tests are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to the following regression:
In a multi zoom setup (mine was left (primary 200%), right (secondary 175%) there is a regression (both with and without update on autoscale) in menus.
We need to treat Menus similar to Shells -> they are always positioned with an absolute value. Currently they are set with two different ways:
however, the locations supplied to these methods are in display coordinate system and hence must be scaled with the right methods as reflected in the PR.