Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatternWin32ManualTest: suppress Discouraged access warning #1620

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Nov 26, 2024

The type 'DPIUtil' is not API (restriction on required project 'org.eclipse.swt.win32.win32.x86_64')

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Test Results

   383 files  ±0     383 suites  ±0   5m 5s ⏱️ +15s
 4 286 tests ±0   4 272 ✅ ±0  14 💤 ±0  0 ❌ ±0 
12 150 runs  ±0  12 065 ✅ ±0  85 💤 ±0  0 ❌ ±0 

Results for commit 423d30b. ± Comparison against base commit 3c1065b.

♻️ This comment has been updated with latest results.

@jukzi
Copy link
Contributor Author

jukzi commented Nov 26, 2024

CI complains about 10 unnecessary @SuppressWarnings("restriction") - what has changed?
image

@jukzi jukzi force-pushed the PatternWin32ManualTest branch from 6662865 to 4a48248 Compare December 2, 2024 12:17
@jukzi jukzi added the junit JUnit test failure label Dec 3, 2024
@akurtakov akurtakov force-pushed the PatternWin32ManualTest branch from 4a48248 to 84dcd35 Compare December 9, 2024 15:23
@jukzi jukzi force-pushed the PatternWin32ManualTest branch from 84dcd35 to 9169683 Compare December 12, 2024 09:03
@jukzi
Copy link
Contributor Author

jukzi commented Dec 12, 2024

CI complains about 10 unnecessary

created #1648

The type 'DPIUtil' is not API (restriction on required project
'org.eclipse.swt.win32.win32.x86_64')
@jukzi jukzi force-pushed the PatternWin32ManualTest branch from 9169683 to 423d30b Compare December 12, 2024 11:48
@jukzi
Copy link
Contributor Author

jukzi commented Dec 12, 2024

3 Failing Test_org_eclipse_swt_browser_Browser are documented in #1564,
Warnings are gone since #1650

However i wonder that the warnings did not decrease by 1 with this PR. The warning is not shown in the CI build on master

@akurtakov
Copy link
Member

That's because the plugin is not enabled in maven build. If you look at

<module>tests/org.eclipse.swt.tests</module>
there is only one test bundle enabled.

@jukzi
Copy link
Contributor Author

jukzi commented Dec 12, 2024

Is it possible and good to add org.eclipse.swt.tests.win32 there?

@akurtakov
Copy link
Member

From releng POV it would probably have to be added in a maven profile as IIRC it uses SWT methods that are internal for the win32 port.
With the above said it's up to people with windows access to evaluate whether it would be beneficial for GHA as Jenkins runs on Linux thus the module will be skipped there.

@jukzi
Copy link
Contributor Author

jukzi commented Dec 12, 2024

lets keep it simple by now: i know the warning is reduced in my workspace - lets merge?

@akurtakov
Copy link
Member

Merge it.

@jukzi jukzi merged commit e8452d8 into eclipse-platform:master Dec 12, 2024
10 of 14 checks passed
@jukzi jukzi deleted the PatternWin32ManualTest branch December 12, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
junit JUnit test failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants