Device getDPI scaling fix #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enforces device zoom to be used for scaling down the DPI values instead of the native zoom. contributes to eclipse-platform#62 and eclipse-platform#127
|
Until CI and I Builds are green again please hold back any submit that does not contribute to that. |
|
This fixes #1671 for me. Thanks. |
fedejeanne
approved these changes
Dec 19, 2024
|
Test failures are unrelated |
|
@fedejeanne I see more test failures and with different errors like https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/PR-1646/1/testReport/junit/org.eclipse.swt.tests.junit/Test_org_eclipse_swt_browser_Browser/test_BrowserFunction_callback_with_boolean_browser_flags__0_/ . Would you please investigate whether it comes from this PR or some of the others just merged (I haven't investigated which one exactly caused it). |
|
Not in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution fixes the device getDPI calculation logic by usibg the device zoom to be used for scaling down the DPI values instead of the native zoom.
contributes to #62 and #127
Fixes #1671