Add Null check before assigning coordinateMapper #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 382 files ±0 382 suites ±0 7m 52s ⏱️ +7s For more details on these failures, see this check. Results for commit a0fc6b6. ± Comparison against base commit 62ad8d9. ♻️ This comment has been updated with latest results. |
This commit adds a null check before assigning the coordinate mapper in the Device::init since it might already be assigned in coordinateMapper. Fixes eclipse-platform#1686 contributes to eclipse-platform#62 and eclipse-platform#127
amartya4256
force-pushed
the
coordinate_revert
branch
from
3feac4e to
a0fc6b6
Compare
fedejeanne
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution adds a null check before assigning the coordinate mapper in the Device::init since it might already be assigned in coordinateMapper.
As of the current implementation, the MultiZoomCoordinateMapper is assigned to coordinateMapper (if rescalingAtRuntime is active) in setRescalingAtRuntime and then it is overwritten in Device:init and always reset to SingleZoomCoordinateSystemMapper which is not the intended behaviour.
Fixes #1686
contributes to #62 and #127