Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for StyledText with fixed font metrics #1689

Conversation

akoch-yatta
Copy link
Contributor

This commit adds a test for StyledText with fixed font metrics that led to a regression with #1610

This commit adds a test for StyledText with fixed font metrics that led to a regression with eclipse-platform#1610
Copy link
Contributor

Test Results

   382 files   -  1     382 suites   - 1   6m 37s ⏱️ +44s
 4 252 tests  - 34   4 242 ✅  - 32   9 💤  - 3  1 ❌ +1 
12 308 runs   - 32  12 216 ✅  - 29  91 💤  - 4  1 ❌ +1 

For more details on these failures, see this check.

Results for commit a3d9e0e. ± Comparison against base commit 534e994.

This pull request removes 35 and adds 1 tests. Note that renamed tests count towards both.
org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testTextTransfer
…
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_custom_StyledText ‑ test_bug1610_fixedLineHeightWithChangingToSmallerFont_noException

@fedejeanne fedejeanne merged commit c088611 into eclipse-platform:master Dec 20, 2024
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants