Skip to content

Commit

Permalink
Fix help webapp compiling JSPs when run on Java 17+
Browse files Browse the repository at this point in the history
Jasper shipped embeds ancient version of ecj which doesn't support
targeting newer Java versions. As Eclipse is the author of ecj it makes
sense to include our own version which is the absolute latest one.
Removed workaround in tests explicitly adding jdt.core that is no longer
needed
Fixes #18
  • Loading branch information
akurtakov committed Jun 23, 2022
1 parent 9c6244e commit 1fc4b6b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
3 changes: 2 additions & 1 deletion org.eclipse.help.webapp/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Export-Package: org.eclipse.help.internal.webapp;x-friends:="org.eclipse.ua.test
org.eclipse.help.webapp
Bundle-RequiredExecutionEnvironment: JavaSE-11
Import-Package: javax.servlet;version="3.1.0",
javax.servlet.http;version="3.1.0"
javax.servlet.http;version="3.1.0",
org.eclipse.jdt.core.compiler
Bundle-ActivationPolicy: lazy
Automatic-Module-Name: org.eclipse.help.webapp
5 changes: 0 additions & 5 deletions org.eclipse.ua.tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@
<id>org.eclipse.equinox.server.jetty</id>
<versionRange>0.0.0</versionRange>
</requirement>
<requirement>
<type>eclipse-plugin</type>
<id>org.eclipse.jdt.core</id>
<versionRange>0.0.0</versionRange>
</requirement>
<requirement>
<type>eclipse-plugin</type>
<id>org.eclipse.help.ui</id>
Expand Down

0 comments on commit 1fc4b6b

Please sign in to comment.