Add missing "static" modifier for constants

To reduce memory per instance
eclipse-platform · Jun 9, 2023 · 902d6ef · 902d6ef
1 parent e8d29df
commit 902d6ef
Show file tree

Hide file tree

Showing 9 changed files with 49 additions and 49 deletions.
diff --git a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/InjectionFilter.java b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/InjectionFilter.java
@@ -37,11 +37,11 @@ public class InjectionFilter implements IFilter {
 	private static final String disabledBook3 = "\n<script type=\"text/javascript\" src=\""; //$NON-NLS-1$
 	private static final String disabledBook4 = "livehelp.js\"> </script>"; //$NON-NLS-1$
 
-	private final String TOPIC_CSS = "topic_css"; //$NON-NLS-1$
-	private final String NAV_CSS   = "nav_css"; //$NON-NLS-1$
-	private final String NARROW_CSS = "narrow_css"; //$NON-NLS-1$
-	private final String DISABLED_CSS = "disabled_css"; //$NON-NLS-1$
-	private final String REMOTE_CSS = "remote_css"; //$NON-NLS-1$
+	private static final String TOPIC_CSS = "topic_css"; //$NON-NLS-1$
+	private static final String NAV_CSS   = "nav_css"; //$NON-NLS-1$
+	private static final String NARROW_CSS = "narrow_css"; //$NON-NLS-1$
+	private static final String DISABLED_CSS = "disabled_css"; //$NON-NLS-1$
+	private static final String REMOTE_CSS = "remote_css"; //$NON-NLS-1$
 	private boolean isRemote;
 
 	public InjectionFilter( boolean isRemote ) {

diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextMergeTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextMergeTest.java
@@ -35,10 +35,10 @@ public class ContextMergeTest {
 	private static final String TOPIC_HEAD_ECLIPSE = "<topic href=\"http://www.eclipse.org\" label=\"enabled\">";
 	private static final String CONTEXT_DESCRIPTION = "<description>Context Description</description>";
 	private static final String CONTEXT_HEAD = "<context id=\"viewer\" title=\"Sample View\">";
-	private final String TOPIC_ECLIPSE = "<topic href=\"http://www.eclipse.org\" label=\"eclipse\"/>";
-	private final String TOPIC_BUGZILLA = "<topic href=\"http://www.eclipse.org/bugzilla\" label=\"bugzilla\"/>";
+	private static final String TOPIC_ECLIPSE = "<topic href=\"http://www.eclipse.org\" label=\"eclipse\"/>";
+	private static final String TOPIC_BUGZILLA = "<topic href=\"http://www.eclipse.org/bugzilla\" label=\"bugzilla\"/>";
 	private final String TOPIC_WITH_ENABLEMENT = TOPIC_HEAD_ECLIPSE + ENABLEMENT_CHEATSHEETS + TOPIC_END;
-	private final String END_CONTEXT = "</context>";
+	private static final String END_CONTEXT = "</context>";
 
 	private Context createContext(final String contextSource) {
 		Context context;

diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextTest.java
@@ -44,17 +44,17 @@ public class ContextTest {
 	private static final String FILTER_OUT = "<filter name = \"plugin\" value = \"org.eclipse.ua.invalid\"/>";
 	private static final String TOPIC_END = "</topic>";
 	private static final String TOPIC_HEAD_ECLIPSE = "<topic href=\"http://www.eclipse.org\" label=\"enabled\">";
-	private final String TOPIC_OLD_FILTER_DISABLED = "<topic filter=\"plugin=org.eclipse.ua.invalid\" href=\"www.eclipse.org\""
+	private static final String TOPIC_OLD_FILTER_DISABLED = "<topic filter=\"plugin=org.eclipse.ua.invalid\" href=\"www.eclipse.org\""
 		+ " label=\"Transformations and transformation configurations\"/>";
 	private static final String CONTEXT_DESCRIPTION = "<description>Context Description</description>";
 	private static final String EMPTY_DESCRIPTION = "<description></description>";
 	private static final String CONTEXT_HEAD = "<context id=\"viewer\" title=\"Sample View\">";
 	private static final String CONTEXT_HEAD_WITH_ATTRIBUTE = "<context id=\"viewer\" title=\"Sample View\" att=\"abc\">";
-	private final String TOPIC_ECLIPSE = "<topic href=\"http://www.eclipse.org\" label=\"eclipse\"/>";
-	private final String TOPIC_WITH_ENABLEMENT = TOPIC_HEAD_ECLIPSE + ENABLEMENT_CHEATSHEETS + TOPIC_END;
-	private final String TOPIC_DISABLED = TOPIC_HEAD_ECLIPSE + ENABLEMENT_INVALID + TOPIC_END;
-	private final String TOPIC_FILTER_OUT = TOPIC_HEAD_ECLIPSE + FILTER_OUT + TOPIC_END;
-	private final String END_CONTEXT = "</context>";
+	private static final String TOPIC_ECLIPSE = "<topic href=\"http://www.eclipse.org\" label=\"eclipse\"/>";
+	private static final String TOPIC_WITH_ENABLEMENT = TOPIC_HEAD_ECLIPSE + ENABLEMENT_CHEATSHEETS + TOPIC_END;
+	private static final String TOPIC_DISABLED = TOPIC_HEAD_ECLIPSE + ENABLEMENT_INVALID + TOPIC_END;
+	private static final String TOPIC_FILTER_OUT = TOPIC_HEAD_ECLIPSE + FILTER_OUT + TOPIC_END;
+	private static final String END_CONTEXT = "</context>";
 
 	@Before
 	public void setUp() throws Exception {

diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/IndexEntryTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/IndexEntryTest.java
@@ -51,23 +51,23 @@ public class IndexEntryTest {
 	private static final String NEGATED_FILTER_OUT = "<filter name = \"plugin\" value = \"!org.eclipse.ua.invalid\"/>";
 	private static final String ENTRY_END = "</entry>";
 	private static final String ENTRY_HEAD_ECLIPSE = "<entry keyword=\"eclipse\">";
-	private final String ENTRY_ECLIPSE = "<entry keyword=\"eclipse\"/>";
-	private final String ENTRY_BUGZILLA = "<entry keyword=\"bugzilla\"/>";
-	private final String TOPIC_BUGZILLA = "<topic href=\"https://bugs.eclipse.org/bugs/\" label=\"bugzilla\"/>";
-	private final String SEE_ALSO_SDK = "<see keyword=\"sdk\"/>";
+	private static final String ENTRY_ECLIPSE = "<entry keyword=\"eclipse\"/>";
+	private static final String ENTRY_BUGZILLA = "<entry keyword=\"bugzilla\"/>";
+	private static final String TOPIC_BUGZILLA = "<topic href=\"https://bugs.eclipse.org/bugs/\" label=\"bugzilla\"/>";
+	private static final String SEE_ALSO_SDK = "<see keyword=\"sdk\"/>";
 
 	private final String ENTRY_WITH_ENABLEMENT = ENTRY_HEAD_ECLIPSE + ENABLEMENT_CHEATSHEETS + ENTRY_END;
 	private final String ENTRY_NOT_ENABLED = ENTRY_HEAD_ECLIPSE + ENABLEMENT_INVALID + ENTRY_END;
 	private final String ENTRY_FILTER_IN = ENTRY_HEAD_ECLIPSE + FILTER_IN + ENTRY_END;
 	private final String ENTRY_FILTER_OUT = ENTRY_HEAD_ECLIPSE + FILTER_OUT + ENTRY_END;
 	private final String ENTRY_FILTER_MIXED = ENTRY_HEAD_ECLIPSE + FILTER_IN + FILTER_OUT + ENTRY_END;
-	private final String ENTRY_OLD_FILTER = "<entry filter=\"plugin=org.eclipse.ua.tests\" "
+	private static final String ENTRY_OLD_FILTER = "<entry filter=\"plugin=org.eclipse.ua.tests\" "
 		+ " keyword=\"Transformations and transformation configurations\"/>";
-	private final String ENTRY_OLD_FILTER_DISABLED = "<entry filter=\"plugin=org.eclipse.ua.invalid\" "
+	private static final String ENTRY_OLD_FILTER_DISABLED = "<entry filter=\"plugin=org.eclipse.ua.invalid\" "
 		+ " keyword=\"Transformations and transformation configurations\"/>";
-	private final String ENTRY_OLD_FILTER_IN__NEGATED = "<entry filter=\"plugin!=org.eclipse.ua.tests\" "
+	private static final String ENTRY_OLD_FILTER_IN__NEGATED = "<entry filter=\"plugin!=org.eclipse.ua.tests\" "
 		+ " keyword=\"Transformations and transformation configurations\"/>";
-	private final String ENTRY_OLD_FILTER_OUT_NEGATED = "<entry filter=\"plugin!=org.eclipse.ua.invalid\" "
+	private static final String ENTRY_OLD_FILTER_OUT_NEGATED = "<entry filter=\"plugin!=org.eclipse.ua.invalid\" "
 		+ " keyword=\"Transformations and transformation configurations\"/>";
 	private final String ENTRY_WITH_CHILD = ENTRY_HEAD_ECLIPSE + ENTRY_BUGZILLA + ENTRY_END;
 	private final String ENTRY_WITH_TOPIC = ENTRY_HEAD_ECLIPSE + TOPIC_BUGZILLA + ENTRY_END;

diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/TopicTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/TopicTest.java
@@ -48,21 +48,21 @@ public class TopicTest {
 	private static final String NEGATED_FILTER_OUT = "<filter name = \"plugin\" value = \"!org.eclipse.ua.invalid\"/>";
 	private static final String TOPIC_END = "</topic>";
 	private static final String TOPIC_HEAD_ECLIPSE = "<topic href=\"http://www.eclipse.org\" label=\"eclipse\">";
-	private final String TOPIC_ECLIPSE = "<topic href=\"http://www.eclipse.org\" label=\"eclipse\"/>";
-	private final String TOPIC_BUGZILLA = "<topic href=\"https://bugs.eclipse.org/bugs/\" label=\"bugzilla\"/>";
+	private static final String TOPIC_ECLIPSE = "<topic href=\"http://www.eclipse.org\" label=\"eclipse\"/>";
+	private static final String TOPIC_BUGZILLA = "<topic href=\"https://bugs.eclipse.org/bugs/\" label=\"bugzilla\"/>";
 
 	private final String TOPIC_WITH_ENABLEMENT = TOPIC_HEAD_ECLIPSE + ENABLEMENT_CHEATSHEETS + TOPIC_END;
 	private final String TOPIC_NOT_ENABLED = TOPIC_HEAD_ECLIPSE + ENABLEMENT_INVALID + TOPIC_END;
 	private final String TOPIC_FILTER_IN = TOPIC_HEAD_ECLIPSE + FILTER_IN + TOPIC_END;
 	private final String TOPIC_FILTER_OUT = TOPIC_HEAD_ECLIPSE + FILTER_OUT + TOPIC_END;
 	private final String TOPIC_FILTER_MIXED = TOPIC_HEAD_ECLIPSE + FILTER_IN + FILTER_OUT + TOPIC_END;
-	private final String TOPIC_OLD_FILTER = "<topic filter=\"plugin=org.eclipse.ua.tests\" href=\"www.eclipse.org\""
+	private static final String TOPIC_OLD_FILTER = "<topic filter=\"plugin=org.eclipse.ua.tests\" href=\"www.eclipse.org\""
 		+ " label=\"Transformations and transformation configurations\"/>";
-	private final String TOPIC_OLD_FILTER_DISABLED = "<topic filter=\"plugin=org.eclipse.ua.invalid\" href=\"www.eclipse.org\""
+	private static final String TOPIC_OLD_FILTER_DISABLED = "<topic filter=\"plugin=org.eclipse.ua.invalid\" href=\"www.eclipse.org\""
 		+ " label=\"Transformations and transformation configurations\"/>";
-	private final String TOPIC_OLD_FILTER_IN__NEGATED = "<topic filter=\"plugin!=org.eclipse.ua.tests\" href=\"www.eclipse.org\""
+	private static final String TOPIC_OLD_FILTER_IN__NEGATED = "<topic filter=\"plugin!=org.eclipse.ua.tests\" href=\"www.eclipse.org\""
 		+ " label=\"Transformations and transformation configurations\"/>";
-	private final String TOPIC_OLD_FILTER_OUT_NEGATED = "<topic filter=\"plugin!=org.eclipse.ua.invalid\" href=\"www.eclipse.org\""
+	private static final String TOPIC_OLD_FILTER_OUT_NEGATED = "<topic filter=\"plugin!=org.eclipse.ua.invalid\" href=\"www.eclipse.org\""
 		+ " label=\"Transformations and transformation configurations\"/>";
 	private final String TOPIC_WITH_CHILD = TOPIC_HEAD_ECLIPSE + TOPIC_BUGZILLA + TOPIC_END;
 

diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/XHTMLEntityTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/XHTMLEntityTest.java
@@ -29,11 +29,11 @@
 import org.w3c.dom.Node;
 
 public class XHTMLEntityTest {
-	private final String XHTML1 = "<?xml version=\"1.0\" encoding=\"ISO-8859-1\"?>\n" +
+	private static final String XHTML1 = "<?xml version=\"1.0\" encoding=\"ISO-8859-1\"?>\n" +
 	"<!DOCTYPE HTML PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\">\n" +
 	"<html xmlns=\"http://www.w3.org/1999/xhtml\" xml:lang=\"en\" lang=\"en\">\n" +
 	"<head></head><body>";
-	private final String XHTML2 = "</body></html>";
+	private static final String XHTML2 = "</body></html>";
 
 	public void checkResolution(String text, int expected) throws Exception {
 		DocumentBuilder documentBuilder;

diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/FilterTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/FilterTest.java
@@ -33,23 +33,23 @@
  */
 
 public class FilterTest {
-	private final String HTML40 =  "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.0 Transitional//EN\">";
-	private final String HEAD1 =  "<HEAD>";
-	private final String HEAD2 = "</HEAD>";
-	private final String HEADLC1 =  "<head>";
-	private final String HEADLC2 = "</head>";
-	private final String CONTENT_TYPE_ISO_8859_1 =    "<meta http-equiv=\"Content-Type\" content=\"text/html; charset=iso-8859-1\">";
-	private final String CONTENT_TYPE_ISO_8859_1_UC = "<meta http-equiv=\"Content-Type\" content=\"text/html; charset=ISO-8859-1\" />";
-	private final String CONTENT_TYPE_UTF8 = "<meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\">";
-	private final String CONTENT_TYPE_UTF8UC = "<META http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\">";
-	private final String BODY1 = "<BODY>";
-	private final String BODY2 = "</BODY></html>";
-	private final String BODYLC1 = "<body>";
-	private final String BODYLC2 = "</body></html>";
-	private final String CSS1 = "<LINK REL=\"STYLESHEET\" HREF=\"book1.css\" TYPE=\"text/css\">";
-	private final String CSS2 = "<LINK REL=\"STYLESHEET\" HREF=\"book1.css\" TYPE=\"text/css\">";
-	private final String CONTENT1 = "<p>Content1</p>";
-	private final String CONTENT2 = "<p>Content2</p>";
+	private static final String HTML40 =  "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.0 Transitional//EN\">";
+	private static final String HEAD1 =  "<HEAD>";
+	private static final String HEAD2 = "</HEAD>";
+	private static final String HEADLC1 =  "<head>";
+	private static final String HEADLC2 = "</head>";
+	private static final String CONTENT_TYPE_ISO_8859_1 =    "<meta http-equiv=\"Content-Type\" content=\"text/html; charset=iso-8859-1\">";
+	private static final String CONTENT_TYPE_ISO_8859_1_UC = "<meta http-equiv=\"Content-Type\" content=\"text/html; charset=ISO-8859-1\" />";
+	private static final String CONTENT_TYPE_UTF8 = "<meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\">";
+	private static final String CONTENT_TYPE_UTF8UC = "<META http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\">";
+	private static final String BODY1 = "<BODY>";
+	private static final String BODY2 = "</BODY></html>";
+	private static final String BODYLC1 = "<body>";
+	private static final String BODYLC2 = "</body></html>";
+	private static final String CSS1 = "<LINK REL=\"STYLESHEET\" HREF=\"book1.css\" TYPE=\"text/css\">";
+	private static final String CSS2 = "<LINK REL=\"STYLESHEET\" HREF=\"book1.css\" TYPE=\"text/css\">";
+	private static final String CONTENT1 = "<p>Content1</p>";
+	private static final String CONTENT2 = "<p>Content2</p>";
 	private String CHINESE_CONTENT = "<p>" + (char)24320 + (char)21457 + (char)29932 + "</p>";
 	private String CHINESE_ENTITY_CONTENT = "<p>&#24320;&#21457;&#29932;</p>";
 

diff --git a/...heatsheets/src/org/eclipse/ui/internal/cheatsheets/registry/CheatSheetRegistryReader.java b/...heatsheets/src/org/eclipse/ui/internal/cheatsheets/registry/CheatSheetRegistryReader.java
@@ -177,7 +177,7 @@ public static CheatSheetRegistryReader getInstance() {
 	protected CheatSheetCollectionElement cheatsheets;
 	private ArrayList<Category> deferCategories = null;
 	private ArrayList<CheatSheetElement> deferCheatSheets = null;
-	private final String csItemExtension = "cheatSheetItemExtension"; //$NON-NLS-1$
+	private static final String csItemExtension = "cheatSheetItemExtension"; //$NON-NLS-1$
 	protected Map<String, TaskExplorerNode> taskExplorers = new HashMap<>();
 	protected Map<String, TaskEditorNode> taskEditors = new HashMap<>();
 	private Map<String, Object> nestedCategoryIds = new HashMap<>();

diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/EclipseRSSViewer.java b/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/EclipseRSSViewer.java
@@ -92,7 +92,7 @@
 
 public class EclipseRSSViewer implements IIntroContentProvider {
 
-	private final int SOCKET_TIMEOUT = 6000; //milliseconds
+	private static final int SOCKET_TIMEOUT = 6000; //milliseconds
 
 	private static final String INTRO_SHOW_IN_BROWSER = "http://org.eclipse.ui.intro/openBrowser?url="; //$NON-NLS-1$