Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include a specific version of gson #151

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

merks
Copy link
Contributor

@merks merks commented Jun 14, 2023

The org.eclipse.tips.json bundle allows a range:

Import-Package: com.google.gson;version="[2.8.6,3.0.0)"

eclipse-platform/eclipse.platform.releng#230

The  org.eclipse.tips.json bundle allows a range:

Import-Package: com.google.gson;version="[2.8.6,3.0.0)"

eclipse-platform/eclipse.platform.releng#230
@merks
Copy link
Contributor Author

merks commented Jun 14, 2023

@akurtakov

This looks the the problem with the broken links, so not related to my correct, right? So it's okay to merge this?

@akurtakov
Copy link
Member

Yes, please merge. I don't have a clue what do to with the doc broken link so I'm leaving this to someone else to figure it out.

@merks merks merged commit 67cd62a into eclipse-platform:master Jun 14, 2023
@merks merks deleted the pr-remove-gson branch June 14, 2023 14:14
@merks
Copy link
Contributor Author

merks commented Jun 14, 2023

I don't know if a link across doc plugins works:

image

That's what's needed here, or the link needs to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants