Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e4] support new jakarta.inject #1129

Closed
laeubi opened this issue Sep 18, 2023 · 3 comments
Closed

[e4] support new jakarta.inject #1129

laeubi opened this issue Sep 18, 2023 · 3 comments

Comments

@laeubi
Copy link
Contributor

laeubi commented Sep 18, 2023 •
edited
Loading

Currently E4 supports javax.* but this is replaced by new jakarta.* namespace:

E4 should allow uses to simply use both annotations in parallel (and maybe even warn in the IDE or at runtime if the "old" namespace is used).
@laeubi laeubi mentioned this issue Sep 18, 2023
Closed
@akurtakov
Copy link
Member

That would be very nice work!

@laeubi laeubi mentioned this issue Sep 18, 2023
Merged
@HannesWell
Copy link
Member

See also eclipse-platform/eclipse.platform.releng.aggregator#1056.

In general I think it should not be too complicated and the injector should simply look for the new and old annotations and the bundle could import both as optional dependencies and should be prepared that both are potentially absent.

laeubi added a commit to laeubi/eclipse.platform that referenced this issue Sep 18, 2023
@laeubi
Support jakarta.inject / jakarta.annotation in E4 as an alternative
ad95228 
The javax.annotation / javax.inject are effectively deprecated as they
are now supersede by the jakarta.inject / jakarta.annotation 2.0 API.

This adds support for E4 to optionally process these annotations as well
so users can migrate their code away from the old namespace.

See eclipse-platform/eclipse.platform.ui#1129
@laeubi laeubi mentioned this issue Sep 18, 2023
Merged
laeubi added a commit to laeubi/eclipse.platform that referenced this issue Sep 18, 2023
@laeubi
Support jakarta.inject / jakarta.annotation in E4 as an alternative
19f1a20 
The javax.annotation / javax.inject are effectively deprecated as they
are now supersede by the jakarta.inject / jakarta.annotation 2.0 API.

This adds support for E4 to optionally process these annotations as well
so users can migrate their code away from the old namespace.

See eclipse-platform/eclipse.platform.ui#1129
laeubi added a commit to laeubi/eclipse.platform that referenced this issue Sep 18, 2023
@laeubi
Support jakarta.inject / jakarta.annotation in E4 as an alternative
d9c8d1f 
The javax.annotation / javax.inject are effectively deprecated as they
are now supersede by the jakarta.inject / jakarta.annotation 2.0 API.

This adds support for E4 to optionally process these annotations as well
so users can migrate their code away from the old namespace.

See eclipse-platform/eclipse.platform.ui#1129
laeubi added a commit to laeubi/eclipse.platform that referenced this issue Sep 19, 2023
@laeubi
Support jakarta.inject / jakarta.annotation in E4 as an alternative
a6d49a6 
The javax.annotation / javax.inject are effectively deprecated as they
are now supersede by the jakarta.inject / jakarta.annotation 2.0 API.

This adds support for E4 to optionally process these annotations as well
so users can migrate their code away from the old namespace.

See eclipse-platform/eclipse.platform.ui#1129
laeubi added a commit to laeubi/eclipse.platform that referenced this issue Sep 19, 2023
@laeubi
Support jakarta.inject / jakarta.annotation in E4 as an alternative
5adab7a 
The javax.annotation / javax.inject are effectively deprecated as they
are now supersede by the jakarta.inject / jakarta.annotation 2.0 API.

This adds support for E4 to optionally process these annotations as well
so users can migrate their code away from the old namespace.

See eclipse-platform/eclipse.platform.ui#1129
laeubi added a commit to laeubi/eclipse.platform that referenced this issue Sep 30, 2023
@laeubi
Support jakarta.inject / jakarta.annotation in E4 as an alternative
c53ea6e 
The javax.annotation / javax.inject are effectively deprecated as they
are now supersede by the jakarta.inject / jakarta.annotation 2.0 API.

This adds support for E4 to optionally process these annotations as well
so users can migrate their code away from the old namespace.

See eclipse-platform/eclipse.platform.ui#1129
laeubi added a commit to laeubi/eclipse.platform that referenced this issue Oct 9, 2023
@laeubi
Support jakarta.inject / jakarta.annotation in E4 as an alternative
6e4c6df 
The javax.annotation / javax.inject are effectively deprecated as they
are now supersede by the jakarta.inject / jakarta.annotation 2.0 API.

This adds support for E4 to optionally process these annotations as well
so users can migrate their code away from the old namespace.

See eclipse-platform/eclipse.platform.ui#1129
laeubi added a commit to eclipse-platform/eclipse.platform that referenced this issue Oct 11, 2023
@laeubi
Support jakarta.inject / jakarta.annotation in E4 as an alternative
9c0f420 
The javax.annotation / javax.inject are effectively deprecated as they
are now supersede by the jakarta.inject / jakarta.annotation 2.0 API.

This adds support for E4 to optionally process these annotations as well
so users can migrate their code away from the old namespace.

See eclipse-platform/eclipse.platform.ui#1129
@HannesWell
Copy link
Member

With eclipse-platform/eclipse.platform#696 merged, I think we can consider this done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akurtakov @laeubi @HannesWell