Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random failure of SmartImportTests.testConfigurationIgnoreNestedProjects #1427

Closed
fedejeanne opened this issue Dec 18, 2023 · 0 comments · Fixed by #1810
Closed

Random failure of SmartImportTests.testConfigurationIgnoreNestedProjects #1427

fedejeanne opened this issue Dec 18, 2023 · 0 comments · Fixed by #1810
Labels
help wanted Extra attention is needed test junit test related things

Comments

@fedejeanne
Copy link
Contributor

Failed on this build of #1404

org.eclipse.ui.tests.datatransfer.SmartImportTests.testConfigurationIgnoreNestedProjects -- Time elapsed: 0.689 s <<< FAILURE!
junit.framework.AssertionFailedError: Root project shouldn't have been configured
	at junit.framework.Assert.fail(Assert.java:57)
	at junit.framework.Assert.assertTrue(Assert.java:22)
	at junit.framework.Assert.assertFalse(Assert.java:39)
	at junit.framework.TestCase.assertFalse(TestCase.java:208)
	at org.eclipse.ui.tests.datatransfer.SmartImportTests.testConfigurationIgnoreNestedProjects(SmartImportTests.java:273)
...
@fedejeanne fedejeanne added bug Something isn't working help wanted Extra attention is needed test junit test related things and removed bug Something isn't working labels Dec 18, 2023
@fedejeanne fedejeanne mentioned this issue Dec 18, 2023
Merged
@BeckerWdf BeckerWdf mentioned this issue Feb 13, 2024
Merged
@BeckerWdf BeckerWdf mentioned this issue Mar 8, 2024
Merged
@BeckerWdf BeckerWdf mentioned this issue Apr 4, 2024
Merged
@Wittmaxi Wittmaxi mentioned this issue Apr 10, 2024
Merged
fedejeanne added a commit to fedejeanne/eclipse.platform.ui that referenced this issue Apr 10, 2024
@fedejeanne
Don't wait for jobs in SmartImportTests
bfbdf4f 
Remove calls to waitForJobs(...) in SmartImportTests and join the
SmartImportJob instead.

Fixes: eclipse-platform#1427
Fixes: eclipse-platform#1807
@fedejeanne fedejeanne mentioned this issue Apr 10, 2024
Merged
fedejeanne added a commit to fedejeanne/eclipse.platform that referenced this issue Apr 11, 2024
@fedejeanne
Add debug information to JobManager to report blocked jobs
2ace1d5 
This should help debugging cases were some jobs are not finished because
they are waiting for other (more important) jobs to finish.

Contributes to
eclipse-platform/eclipse.platform.ui#1427
Contributes to
eclipse-platform/eclipse.platform.ui#1807
@fedejeanne fedejeanne mentioned this issue Apr 11, 2024
Merged
fedejeanne added a commit to fedejeanne/eclipse.platform.ui that referenced this issue Apr 11, 2024
@fedejeanne
Rename method in SmartImportJob and add getCurrentImportJob
a77cce6 
- Rename "getImportJob" to "createOrGetConfiguredImportJob" to better
express its behavior and also change its JavaDoc.
- Add a new method "getCurrentImportJob" that merely retrieves the
current job (without creating/configuring anything).
- Extract private method in SmartImportTests
- Remove calls to waitForJobs(...) in SmartImportTests and join the
SmartImportJob instead.

Fixes: eclipse-platform#1427
Fixes: eclipse-platform#1807
fedejeanne added a commit to fedejeanne/eclipse.platform.ui that referenced this issue Apr 12, 2024
@fedejeanne
Rename method in SmartImportJob and add getCurrentImportJob
e033414 
- Rename "getImportJob" to "createOrGetConfiguredImportJob" to better
express its behavior and also change its JavaDoc.
- Add a new method "getCurrentImportJob" that merely retrieves the
current job (without creating/configuring anything).
- Extract private method in SmartImportTests
- Remove calls to waitForJobs(...) in SmartImportTests and join the
SmartImportJob instead.

Fixes: eclipse-platform#1427
Fixes: eclipse-platform#1807
fedejeanne added a commit to fedejeanne/eclipse.platform.ui that referenced this issue Apr 12, 2024
@fedejeanne
Rename method in SmartImportJob and add getCurrentImportJob
ffc46be 
- Rename "getImportJob" to "createOrGetConfiguredImportJob" to better
express its behavior and also change its JavaDoc.
- Add a new method "getCurrentImportJob" that merely retrieves the
current job (without creating/configuring anything).
- Extract private method in SmartImportTests
- Remove calls to waitForJobs(...) in SmartImportTests and join the
SmartImportJob instead.

Fixes: eclipse-platform#1427
Fixes: eclipse-platform#1807
fedejeanne added a commit that referenced this issue Apr 12, 2024
@fedejeanne
Rename method in SmartImportJob and add getCurrentImportJob
85f59c5 
- Rename "getImportJob" to "createOrGetConfiguredImportJob" to better
express its behavior and also change its JavaDoc.
- Add a new method "getCurrentImportJob" that merely retrieves the
current job (without creating/configuring anything).
- Extract private method in SmartImportTests
- Remove calls to waitForJobs(...) in SmartImportTests and join the
SmartImportJob instead.

Fixes: #1427
Fixes: #1807
fedejeanne added a commit to eclipse-platform/eclipse.platform that referenced this issue Apr 18, 2024
@fedejeanne
Add debug information to JobManager to report blocked jobs
693edd9 
This should help debugging cases were some jobs are not finished because
they are waiting for other (more important) jobs to finish.

Contributes to
eclipse-platform/eclipse.platform.ui#1427
Contributes to
eclipse-platform/eclipse.platform.ui#1807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed test junit test related things
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't wait for jobs in SmartImportTests fedejeanne/eclipse.platform.ui
1 participant
@fedejeanne