Find/replace overlay: border size #2194
Labels
bug
Something isn't working
Comments
67 tasks
|
occurs on Ubuntu too |
|
This always occurs if the replace toggle is not visible, e.g., also when it is hidden because the overlay is too small: Reason is that the container grid layout always expects two colums but when the replace toggle is hidden only one exists, leading to an empty grid column. |
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this issue
Nov 1, 2024
When the replace toggle in the FindReplaceOverlay is not shown because the target file is read-only or because the editor is too small to show the toggle button, the right border of the overlay is larger than the others. The reason is an inconsistent layout, as the container always expects two columns of elements but when the replace toggle is hidden only one column is present. With this change, the number of columns of the container is adapted according to whether the replace toggle is present or not. Fixed eclipse-platform#2194
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this issue
Nov 1, 2024
When the replace toggle in the FindReplaceOverlay is not shown because the target file is read-only or because the editor is too small to show the toggle button, the right border of the overlay is larger than the others. The reason is an inconsistent layout, as the container always expects two columns of elements but when the replace toggle is hidden only one column is present. With this change, the number of columns of the container is adapted according to whether the replace toggle is present or not. Fixed eclipse-platform#2194
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this issue
Nov 2, 2024
When the replace toggle in the FindReplaceOverlay is not shown because the target file is read-only or because the editor is too small to show the toggle button, the right border of the overlay is larger than the others. The reason is an inconsistent layout, as the container always expects two columns of elements but when the replace toggle is hidden only one column is present. With this change, the number of columns of the container is adapted according to whether the replace toggle is present or not. Fixed eclipse-platform#2194
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this issue
Nov 2, 2024
When the replace toggle in the FindReplaceOverlay is not shown because the target file is read-only or because the editor is too small to show the toggle button, the right border of the overlay is larger than the others. The reason is an inconsistent layout, as the container always expects two columns of elements but when the replace toggle is hidden only one column is present. With this change, the number of columns of the container is adapted according to whether the replace toggle is present or not. Fixed eclipse-platform#2194
HeikoKlare
added a commit
that referenced
this issue
Nov 3, 2024
When the replace toggle in the FindReplaceOverlay is not shown because the target file is read-only or because the editor is too small to show the toggle button, the right border of the overlay is larger than the others. The reason is an inconsistent layout, as the container always expects two columns of elements but when the replace toggle is hidden only one column is present. With this change, the number of columns of the container is adapted according to whether the replace toggle is present or not. Fixed #2194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Very minor issue:
On windows, default light theme: the inner border size of the overlay search is unbalanced if (and only if) used on a read only document like a .class file. On the left it is 2 pixels, on the right it is 3 pixels. Screenshot:
@Wittmaxi
The text was updated successfully, but these errors were encountered: