Link GenericEditorMergeViewer to generic editor id #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows GenericEditorMergeViewer be used by compare editor for content types associated with the generic editor. Additionally implemented getTitle() to provide more specific compare editor description, so instead of default "Text Compare" one would see "XML Compare" etc. This avoids the problem of duplicated "Text Compare" options shown for different compare viewers (default one for plain text and the one for generic editor). See eclipse-platform#1747 See eclipse-platform/eclipse.platform#1277
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows GenericEditorMergeViewer be used by compare editor for content types associated with the generic editor.
Additionally implemented getTitle() to provide more specific compare editor description, so instead of default "Text Compare" one would see "XML Compare" etc. This avoids the problem of duplicated "Text Compare" options shown for different compare viewers (default one for plain text and the one for generic editor).
See #1747
See eclipse-platform/eclipse.platform#1277