Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement activity support filtering for e4 dynamic menu contribution. #2222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement activity support filtering for e4 dynamic menu contribution. #2222

wants to merge 1 commit into from

Conversation

raghucssit
Copy link
Contributor

Similar to PluginActionContributionItem we can support activity filtering of menu item to be shown or not.

see #2217

@raghucssit raghucssit force-pushed the activity_support_e4_dynamic_menu_contribution branch from 492585f to 69e65fa Compare August 26, 2024 20:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024 •
edited
Loading

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 44m 50s ⏱️ - 12m 40s
 7 725 tests ±0   7 497 ✅ +1  228 💤 ±0  0 ❌  - 1 
24 336 runs  ±0  23 589 ✅ +1  747 💤 ±0  0 ❌  - 1 

Results for commit 572aa2a. ± Comparison against base commit 69f6e45.

♻️ This comment has been updated with latest results.

@raghucssit
Copy link
Contributor Author

@iloveeclipse FYI

@laeubi laeubi added the noteworthy Noteworthy feature label Aug 28, 2024
@iloveeclipse iloveeclipse force-pushed the activity_support_e4_dynamic_menu_contribution branch from 69e65fa to 57adcf5 Compare October 1, 2024 11:57
@iloveeclipse
Copy link
Member

I've just rebased on head to see current test result.

@iloveeclipse iloveeclipse force-pushed the activity_support_e4_dynamic_menu_contribution branch from 57adcf5 to 00b0685 Compare October 1, 2024 13:11
iloveeclipse
iloveeclipse requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on latest master before next update.

...ipse.e4.ui.workbench3/src/org/eclipse/ui/internal/activitysupport/IActivityManagerProxy.java Outdated Show resolved Hide resolved
...ipse.e4.ui.workbench3/src/org/eclipse/ui/internal/activitysupport/IActivityManagerProxy.java Outdated Show resolved Hide resolved
...s/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/util/ActivityManagerProxy.java Outdated Show resolved Hide resolved
...s/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/util/ActivityManagerProxy.java Outdated Show resolved Hide resolved
bundles/org.eclipse.e4.ui.workbench3/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
@raghucssit raghucssit force-pushed the activity_support_e4_dynamic_menu_contribution branch 2 times, most recently from 30f6fc5 to 39d5b25 Compare October 8, 2024 11:23
iloveeclipse
iloveeclipse requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only few minor issues left

bundles/org.eclipse.e4.ui.workbench/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
...es/org.eclipse.e4.ui.workbench/src/org/eclipse/ui/activitysupport/IActivityManagerProxy.java Outdated Show resolved Hide resolved
...ipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisor.java Outdated Show resolved Hide resolved
...s/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/util/ActivityManagerProxy.java Outdated Show resolved Hide resolved
bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
@iloveeclipse
Copy link
Member

@raghucssit : could you please update the fix & rebase?

@raghucssit raghucssit force-pushed the activity_support_e4_dynamic_menu_contribution branch 4 times, most recently from 02bda66 to 71fdd59 Compare November 14, 2024 18:49
@raghucssit
Implement activity support filtering for e4 dynamic menu contribution.
572aa2a 
Similar to PluginActionContributionItem we can support activity
filtering of menu item to be shown or not.

see eclipse-platform#2217
@raghucssit raghucssit force-pushed the activity_support_e4_dynamic_menu_contribution branch from 71fdd59 to 572aa2a Compare November 14, 2024 20:56
@raghucssit
Copy link
Contributor Author

#2217 (comment)
This issue was due to the scheme that e4 view contribution follows.
All the old view contributions have the same URI bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView.
But e4 view contributions have distinct uri for each contribution like bundleclass://org.eclipse.pde.spy.bundle/org.eclipse.pde.spy.bundle.BundleSpyPart.
And all follows the same prefix scheme bundleclass://. In case of e4 view, we just have to use it's actual URI to ask activity support if it is enabled or not. Because activity support checks pattern that are defined and patterns always use bundle/element scheme.

@raghucssit
Copy link
Contributor Author

@iloveeclipse I have fixed all the review comments and Quick Access leak also. Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iloveeclipse iloveeclipse Awaiting requested review from iloveeclipse

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
noteworthy Noteworthy feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raghucssit @iloveeclipse @laeubi