Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IllegalStateException: call to beginTask() missing in the Help view #1002

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

iloveeclipse
Copy link
Member

This patch fixes following warning reported to the error log while navigating between help topics in the Help view after eclipse-platform/eclipse.platform.ui#1077:

java.lang.IllegalStateException: call to beginTask() missing
	at org.eclipse.jface.action.StatusLineManager$1.worked(StatusLineManager.java:221)
	at org.eclipse.help.ui.internal.views.BrowserPart$2.changed(BrowserPart.java:148)
	at org.eclipse.swt.browser.WebKit.lambda$15(WebKit.java:2492)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)

To avoid errors reported by the different monitor instances returned by IStatusLineManager.getProgressMonitor(), browser listener has to keep a single local monitor instance.

See eclipse-platform/eclipse.platform.ui#1398

This patch fixes following warning reported to the error log while
navigating between help topics in the Help view after
eclipse-platform/eclipse.platform.ui#1077:

java.lang.IllegalStateException: call to beginTask() missing
	at org.eclipse.jface.action.StatusLineManager$1.worked(StatusLineManager.java:221)
	at org.eclipse.help.ui.internal.views.BrowserPart$2.changed(BrowserPart.java:148)
	at org.eclipse.swt.browser.WebKit.lambda$15(WebKit.java:2492)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)

To avoid errors reported by the different monitor instances returned by
`IStatusLineManager.getProgressMonitor()`, browser listener has to keep
a single local monitor instance.

See eclipse-platform/eclipse.platform.ui#1398
Copy link
Contributor

Test Results

     594 files  ±0       594 suites  ±0   1h 10m 39s ⏱️ - 6m 2s
  3 855 tests ±0    3 836 ✔️ ±0    19 💤 ±0  0 ±0 
12 171 runs  ±0  12 019 ✔️ ±0  152 💤 ±0  0 ±0 

Results for commit 3b70113. ± Comparison against base commit 8a75d7c.

@iloveeclipse
Copy link
Member Author

Real tests didn't fail, only some warnings that are treated as errors now.
Ignoring errors, looks like they are unavoidable: #969

@iloveeclipse iloveeclipse merged commit 610d57f into eclipse-platform:master Dec 12, 2023
13 of 16 checks passed
@iloveeclipse iloveeclipse deleted the issue_1398 branch December 12, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant