Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove activate="activate" #1006

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Remove activate="activate" #1006

merged 1 commit into from
Dec 12, 2023

Conversation

merks
Copy link
Contributor

@merks merks commented Dec 12, 2023

@merks
Copy link
Contributor Author

merks commented Dec 12, 2023

@iloveeclipse

Please merge this when it's ready.

@iloveeclipse
Copy link
Member

Please merge this when it's ready.

If that is what expected to be in the source tree, I will do that. However I have no clue about this code.

@github-actions GitHub Actions
Copy link
Contributor

Test Results

     594 files  ±0       594 suites  ±0   1h 30m 41s ⏱️ + 12m 2s
  3 855 tests ±0    3 836 ✔️ ±0    19 💤 ±0  0 ❌ ±0 
12 171 runs  ±0  12 019 ✔️ ±0  152 💤 ±0  0 ❌ ±0 

Results for commit 2e69da4. ± Comparison against base commit 610d57f.

@merks
Copy link
Contributor Author

merks commented Dec 12, 2023

Either they should be committed in the current generated state or not committed at all. But the latter can be done later.

I'm not sure what to make of the failures. 😱

@iloveeclipse
Copy link
Member

I'm not sure what to make of the failures.

You are not alone. That's the "quality gate", see #969

@iloveeclipse
Copy link
Member

Tests are fine: https://ci.eclipse.org/platform/job/eclipse.platform/job/PR-1006/1/testReport/
image

@iloveeclipse iloveeclipse merged commit c417108 into eclipse-platform:master Dec 12, 2023
13 of 16 checks passed
@iloveeclipse
Copy link
Member

Thanks Ed.

@iloveeclipse iloveeclipse mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merks @iloveeclipse