Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkinsfile: Disable Quality gate for maven warnings #969 #1007

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Dec 12, 2023

should be revert if #969 is fixed
The Problem is, that almost every build fails because the number of warnings is too flaky and independent of the PRs that they should verify. If they would be at least constant they would not fail the PRs.
image

Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Contributor

Test Results

     594 files  ±0       594 suites  ±0   1h 24m 29s ⏱️ + 14m 36s
  3 855 tests ±0    3 836 ✔️ ±0    19 💤 ±0  0 ±0 
12 171 runs  ±0  12 019 ✔️ ±0  152 💤 ±0  0 ±0 

Results for commit 183df37. ± Comparison against base commit c417108.

@jukzi
Copy link
Contributor Author

jukzi commented Dec 12, 2023

only warnings, no errors => success
image

@jukzi jukzi merged commit 5a4d891 into eclipse-platform:master Dec 12, 2023
16 checks passed
@jukzi jukzi deleted the disableMavenWarni branch December 12, 2023 17:45
@laeubi
Copy link
Contributor

laeubi commented Dec 13, 2023

The Problem is, that almost every build fails because the number of warnings is too flaky and independent of the PRs that they should verify. If they would be at least constant they would not fail the PRs.

The warnings are about an possible instability in build, therefore they vary dependent on the build execution order (and that's what the warning is complaining about) so it can never be constant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants