Migrate BasicAliasTest and SyncAliasTest to JUnit 5 #903 #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 734 files + 149 1 734 suites +149 1h 27m 41s ⏱️ + 5m 28s Results for commit 47e92a8. ± Comparison against base commit 3c40369. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This change migrates the alias tests (BasicAliasTest and SyncAliasTest) to JUnit 5. It replaces the usage of the WorkspaceTestRule with the WorkspaceResetExtension as. The deletion of files and file stores via the WorkspaceTestRule is replaced with dedicated file delete operations exactly where they are required. The creation of temporary file stores is replaced with the usage of temporary directories that are automatically cleaned up via the according JUnit 5 extension. The recursive folder deletion implementation from the SessionCustomizationUtil is used by generalizing it to the FileSystemHelper class. Contributes to eclipse-platform#903
HeikoKlare
force-pushed
the
junit5-aliastests
branch
from
326bd9c
to
47e92a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change migrates the alias tests (BasicAliasTest and SyncAliasTest) to JUnit 5. It replaces the usage of the WorkspaceTestRule with the WorkspaceResetExtension as. The deletion of files and file stores via the WorkspaceTestRule is replaced with dedicated file delete operations exactly where they are required. The creation of temporary file stores is replaced with the usage of temporary directories that are automatically cleaned up via the according JUnit 5 extension. The recursive folder deletion implementation from the SessionCustomizationUtil is used by generalizing it to the FileSystemHelper class.
Contributes to #903