Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use equinox preferences APIs in FileSystemResourceManager class #497 #573

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

alex2145
Copy link
Contributor

Replace deprecated preferences APIs.

Partially fixes
#497

@github-actions
Copy link
Contributor

Test Results

       42 files  ±0         42 suites  ±0   51m 19s ⏱️ - 4m 26s
  3 755 tests +1    3 751 ✔️ +1    4 💤 ±0  0 ±0 
11 268 runs  +3  11 238 ✔️ +3  30 💤 ±0  0 ±0 

Results for commit fd9a88e. ± Comparison against base commit 1422671.

@jukzi
Copy link
Contributor

jukzi commented Jul 25, 2023

When is the code used? - How could somebody test the change?

@alex2145
Copy link
Contributor Author

Modified code is executed during FileSystemResourceManager startup & shutdown and when the value of the preference refresh.lightweight.enabled of the ResourcesPlugin changes (Window -> Preferences -> General -> Workspace -> Refresh on access).

In my commit there's a Junit test case in case you didn't notice.

@jukzi jukzi merged commit b84f6d5 into eclipse-platform:master Jul 31, 2023
@jukzi
Copy link
Contributor

jukzi commented Jul 31, 2023

works. @alex2145 thanks for contributing

@alex2145 alex2145 deleted the iss497 branch August 2, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants