Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move create/ensure methods from ResourceTest to utility class #903 #905

Conversation

HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented Nov 30, 2023

This changes moves all create*/ensure* utility methods defined in ResourceTest to the dedicated ResourceTestUtil test class. It renames the ensureDoesNotExist* methods to remove* to avoid name clashes and make the performed removal more explicit. It prepares for removing the JUnit 3 test inheritances hierarchy to migrate to JUnit 4.

Contributes to #903

⚠️ Depends on and currently contains the changes of #904, so has to be merged afterwards.

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Test Results

     591 files  ±0       591 suites  ±0   1h 6m 36s ⏱️ - 5m 4s
  3 842 tests ±0    3 837 ✔️ ±0    5 💤 ±0  0 ±0 
12 132 runs  ±0  12 096 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit 11a27a6. ± Comparison against base commit c75e9a1.

♻️ This comment has been updated with latest results.

…pse-platform#903

This changes moves all assert* utility methods defined in ResourceTest
to a dedicated ResourceTestUtil test class. It prepares for removing the
JUnit 3 test inheritances hierarchy to migrate to JUnit 4.

Contributes to
eclipse-platform#903
…-platform#903

This changes moves all create*/ensure* utility methods defined in
ResourceTest to the dedicated ResourceTestUtil test class. It renames
the ensureDoesNotExist* methods to remove* to avoid name clashes and
make the performed removal more explicit. It prepares for removing the
JUnit 3 test inheritances hierarchy to migrate to JUnit
4.

Contributes to
eclipse-platform#903
@HeikoKlare HeikoKlare force-pushed the ResourceTest-extract-utils-ensure branch from b82241f to 11a27a6 Compare December 1, 2023 17:54
@HeikoKlare
Copy link
Contributor Author

Obsolete due to #951.

@HeikoKlare HeikoKlare closed this Dec 7, 2023
@HeikoKlare HeikoKlare deleted the ResourceTest-extract-utils-ensure branch December 8, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant