Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change making jdt compiler use project settings #975

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

akurtakov
Copy link
Member

Should fix
eclipse-platform/eclipse.platform.releng.aggregator#1653 .
Further work on the topic could be continued as described in #973 (comment)

@akurtakov
Copy link
Member Author

Push without waiting as comparator issues shouldn't break the verification build and start I-build to get results ASAP.

@akurtakov akurtakov merged commit a82a4d0 into eclipse-platform:master Dec 11, 2023
4 of 10 checks passed
akurtakov added a commit to akurtakov/eclipse.platform that referenced this pull request Dec 11, 2023
@akurtakov akurtakov mentioned this pull request Dec 11, 2023
akurtakov added a commit that referenced this pull request Dec 11, 2023
@jukzi
Copy link
Contributor

jukzi commented Dec 12, 2023

Since the comparator issue was analysed anderstood can this revert be reverted and comparator get a reset?

@akurtakov
Copy link
Member Author

@srikanth-sankaran @iloveeclipse WDYT ? Should we go for preserveLocal and touch all needed bundles?

If that's the path recomended by compiler guys the change should happen in https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/3e6518b64e478f6f31375307c185eaf15706d9e6/eclipse-platform-parent/pom.xml#L485 and not be a revert of this one.

@iloveeclipse
Copy link
Member

Alex, I'm for a buuild that uses (consistent) project settings accross all projects in aggregator.
Ideally what project defines in settings should be used in all project builds - IDE, Jenkins, SDK aggregator build.
If that line in parent pom makes it - perfect.
We should check before if all the various Jenkins files and poms don't override that again with something different. And ideally we should check if all the projects have compiler settings at all.
Unfortunately I can't commit to drive that, as I'm busy with other tasks.

Michael5601 pushed a commit to CodeLtDave/eclipse.platform that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants