Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate all tests in o.e.c.tests.internal.mapping to JUnit 4 #903 #985

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Migrate all tests in o.e.c.tests.internal.mapping to JUnit 4 #903 #985

merged 1 commit into from
Dec 11, 2023

Conversation

HeikoKlare
Copy link
Contributor

  • Replace the ResourceTest class hierarchy with WorkspaceTestRule
  • Add @Test annotations

Contributes to #903

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2023 •
edited
Loading

Test Results

     591 files  +  42       591 suites  +42   1h 2m 27s ⏱️ + 7m 10s
  3 851 tests ±    0    3 836 ✔️ ±    0    15 💤 ±0  0 ❌ ±0 
12 159 runs  +386  12 032 ✔️ +386  127 💤 ±0  0 ❌ ±0 

Results for commit 46d2dd0. ± Comparison against base commit 29ba3b3.

♻️ This comment has been updated with latest results.

@HeikoKlare
Migrate all tests in o.e.c.tests.internal.mapping to JUnit 4 eclipse-…
46d2dd0 
…platform#903

* Replace the ResourceTest class hierarchy with WorkspaceTestRule
* Add @test annotations

Contributes to
eclipse-platform#903
@HeikoKlare HeikoKlare force-pushed the migrate-junit4-internal.mapping branch from fb594d7 to 46d2dd0 Compare December 11, 2023 16:24
@HeikoKlare HeikoKlare marked this pull request as ready for review December 11, 2023 16:39
@HeikoKlare
Copy link
Contributor Author

Ignoring unrelated Maven and ECJ warnings in Jenkins build.

@HeikoKlare HeikoKlare merged commit ededd44 into eclipse-platform:master Dec 11, 2023
12 of 16 checks passed
@HeikoKlare HeikoKlare deleted the migrate-junit4-internal.mapping branch December 11, 2023 16:52
@akurtakov
Copy link
Member

The pattern of ignoring warnings starts to bother me (once people get used to ignoring things become bad fast) - we should have smth bad in our config if unrelated warnings pop ups.
@HeikoKlare Have you looked at the underlying issues?

@HeikoKlare
Copy link
Contributor Author

@akurtakov I totally agree with you. My wording was just too sloppy: I do never really ignore warnings but just did not consider them for this (and other) PRs, as they are really unrelated and already tracked in other issues/PR:

  1. org.osgi.service.http: Unable to satisfy dependency  #969
    Tracks the Maven warnings, which will be resolved in Equinox: Replace embedded service.http sources in org.eclipse.osgi.services by original bundles and deprecate o.e.osgi.services eclipse-equinox/equinox#403
  2. Use PreferencesService.prependScopeToDefaultDefaultLookupOrder() #972
    Tracks the changes necessary to resolve the ECJ warnings, which are a result of deprecations in Equinox: Replace embedded service.http sources in org.eclipse.osgi.services by original bundles and deprecate o.e.osgi.services eclipse-equinox/equinox#403

@akurtakov
Copy link
Member

@laeubi eclipse-tycho/tycho@697dc92 should stabilize/improve things at least with less warnings, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeikoKlare @akurtakov