Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate remaining tests in o.e.compare.tests to JUnit 4 #903 #990

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Migrate remaining tests in o.e.compare.tests to JUnit 4 #903 #990

merged 1 commit into from
Dec 12, 2023

Conversation

HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented Dec 12, 2023 •
edited
Loading

The only remaining JUnit 4 test in org.eclipse.compare.tests is FileDiffResultTest:

  • Replace the ResourceTest inheritance with WorkspaceTestRule
  • Add @Test annotations
  • Remove unnecessary try-catch blocks
  • Replace inheritance of utilities from WorkspaceTest with proper in-place functionality

Contributes to #903

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

Test Results

     594 files  +3       594 suites  +3   1h 8m 33s ⏱️ + 10m 25s
  3 854 tests ±0    3 835 ✔️ ±0    19 💤 ±0  0 ❌ ±0 
12 168 runs  ±0  12 016 ✔️ ±0  152 💤 ±0  0 ❌ ±0 

Results for commit 97b5d65. ± Comparison against base commit 843a8ee.

This pull request removes 5 and adds 5 tests. Note that renamed tests count towards both. 
org.eclipse.compare.tests.AllCompareTests ‑ testExcludePartOfNonWorkspacePatch
org.eclipse.compare.tests.AllCompareTests ‑ testFileDiffResultWithNullPath
org.eclipse.compare.tests.AllCompareTests ‑ testPatchAddsExistingFileWithDifferentContents
org.eclipse.compare.tests.AllCompareTests ‑ testPatchAddsExistingFileWithSameContents
org.eclipse.compare.tests.AllCompareTests ‑ testPatchAddsNewFile

AllCompareTests org.eclipse.compare.tests.FileDiffResultTest ‑ testExcludePartOfNonWorkspacePatch
AllCompareTests org.eclipse.compare.tests.FileDiffResultTest ‑ testFileDiffResultWithNullPath
AllCompareTests org.eclipse.compare.tests.FileDiffResultTest ‑ testPatchAddsExistingFileWithDifferentContents
AllCompareTests org.eclipse.compare.tests.FileDiffResultTest ‑ testPatchAddsExistingFileWithSameContents
AllCompareTests org.eclipse.compare.tests.FileDiffResultTest ‑ testPatchAddsNewFile

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare marked this pull request as ready for review December 12, 2023 08:42
@HeikoKlare HeikoKlare force-pushed the migrate-junit4.compare-tests branch 2 times, most recently from 070b626 to 0950534 Compare December 12, 2023 09:11
@HeikoKlare
Migrate remaining tests in o.e.compare.tests to JUnit 4 eclipse-platf…
97b5d65 
…orm#903

The only remaining JUnit 4 test in org.eclipse.compare.tests is
FileDiffResultTest:
* Replace the ResourceTest inheritance with WorkspaceTestRule
* Add @test annotations
* Remove unnecessary try-catch blocks
* Replace inheritance of utilities from WorkspaceTest with proper
in-place functionality

Contributes to
eclipse-platform#903
@HeikoKlare
Copy link
Contributor Author

Maven warnings in Jenkins build are unrelated, see #969.

@HeikoKlare HeikoKlare merged commit cb5adeb into eclipse-platform:master Dec 12, 2023
13 of 16 checks passed
@HeikoKlare HeikoKlare deleted the migrate-junit4.compare-tests branch December 12, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HeikoKlare