Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify auto-save configurations #991

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

HeikoKlare
Copy link
Contributor

The auto-save configurations are not streamlined across the projects. This change unifies the configuration in the following way:

  • Enable auto-formatting for edited lines
  • Activate import organization

The change does explicitly not change/unify any additional auto-save actions.

Added configuration parameters (set to false) are only due to further options being added to JDT. In case it is preferred to not have these options added to the configuration files but only the entries for auto-formatting and import organization to be changed, I can adapt the PR accordingly. That would affect:

  • sp_cleanup.organize_imports=true
  • sp_cleanup.format_source_code=true
  • sp_cleanup.format_source_code_changes_only=true

The auto-save configurations are not streamlined across the projects.
This change unifies the configuration in the following way:
* Enable auto-formatting for edited lines
* Activate import organization

The change does explicitly not change/unify any additional auto-save
actions. Added configuration parameters are only due to further options
being added to JDT.
@akurtakov
Copy link
Member

It might be good idea to have one step further and even enable more save actions by default e.g. simplify_lambda* .

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Test Results

     591 files  +    2       591 suites  +2   1h 5m 12s ⏱️ +14s
  3 854 tests ±    0    3 835 ✔️ ±    0    19 💤 ±0  0 ±0 
12 168 runs  +412  12 016 ✔️ +410  152 💤 +2  0 ±0 

Results for commit 2cf1f6a. ± Comparison against base commit 73b85e8.

♻️ This comment has been updated with latest results.

@HeikoKlare
Copy link
Contributor Author

It might be good idea to have one step further and even enable more save actions by default e.g. simplify_lambda* .

Agreed. I would propose to do that in a follow-up PR (to keep changes separate and as it will affect even more plug-ins) or would you propose to incorporate it into this PR?

@akurtakov
Copy link
Member

It might be good idea to have one step further and even enable more save actions by default e.g. simplify_lambda* .

Agreed. I would propose to do that in a follow-up PR (to keep changes separate and as it will affect even more plug-ins) or would you propose to incorporate it into this PR?

Fully agreed. Let's keep PRs on topic.
+1 for this one as it is.

@HeikoKlare HeikoKlare marked this pull request as ready for review December 12, 2023 10:59
@HeikoKlare
Copy link
Contributor Author

Maven warnings in Jenkins build are unrelated, see #969.

@HeikoKlare HeikoKlare merged commit 0c5ee0b into eclipse-platform:master Dec 12, 2023
13 of 16 checks passed
@HeikoKlare HeikoKlare deleted the unify-auto-save branch December 12, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants