Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in o.e.team.tests.core related to FileModificationValidator #993

Conversation

HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented Dec 12, 2023

The test implementations PessimisticRepositoryProvider, RepositoryProviderBic, and RepositoryProviderNaish use deprecated
API for the FileModificationValidator. This change adapts to the new API by changing from IFileModificationValidator to FileModificationValidator and by extracting the validation within PessimisticRepositoryProvider into a static inner class.

The test implementations PessimisticRepositoryProvider,
RepositoryProviderBic, and RepositoryProviderNaish use deprecated
API for the FileModificationValidator. This change adapts to the new API
by changing from IFileModificationValidator to FileModificationValidator
and by extracting the validation within PessimisticRepositoryProvider
into a static inner class.
@HeikoKlare HeikoKlare force-pushed the warnings-PessimisticRepositoryProvider branch from 4505a63 to 72675e3 Compare December 12, 2023 11:26
@HeikoKlare HeikoKlare changed the title Fix warnings in PessimisticRepositoryProvider Fix warnings in o.e.team.tests.core related to FileModificationValidator Dec 12, 2023
Copy link
Contributor

Test Results

     594 files  +    2       594 suites  +2   1h 3m 59s ⏱️ + 2m 55s
  3 854 tests ±    0    3 835 ✔️ ±    0    19 💤 ±0  0 ±0 
12 168 runs  +412  12 016 ✔️ +410  152 💤 +2  0 ±0 

Results for commit 72675e3. ± Comparison against base commit 0c5ee0b.

@HeikoKlare HeikoKlare marked this pull request as ready for review December 12, 2023 11:59
@HeikoKlare
Copy link
Contributor Author

Maven warnings in Jenkins build are unrelated, see #969.

@HeikoKlare HeikoKlare merged commit 182c0f7 into eclipse-platform:master Dec 12, 2023
13 of 16 checks passed
@HeikoKlare HeikoKlare deleted the warnings-PessimisticRepositoryProvider branch December 12, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant