Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate all tests in o.e.team.tests.core.* to JUnit 4 #903 #997

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Migrate all tests in o.e.team.tests.core.* to JUnit 4 #903 #997

merged 1 commit into from
Dec 12, 2023

Conversation

HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented Dec 12, 2023 •
edited
Loading

  • Replace the ResourceTest inheritance with WorkspaceTestRule
  • Add @Test annotations
  • Remove unnecessary try-catch blocks
  • Replace inheritance of utilities from WorkspaceTest with proper in-place functionality
  • Replace calls to deprecated API in StorageMergerTest

Contributes to #903

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

Test Results

     594 files  +  19       594 suites  +19   1h 1m 37s ⏱️ - 9m 57s
  3 854 tests ±    0    3 835 ✔️ +    1    19 💤 ±0  0 ❌  - 1 
12 168 runs  +147  12 016 ✔️ +148  152 💤 ±0  0 ❌  - 1 

Results for commit fdc87e0. ± Comparison against base commit 3bd68b7.

♻️ This comment has been updated with latest results.

@HeikoKlare
Migrate all tests in o.e.team.tests.core.* to JUnit 4 eclipse-platfor…
fdc87e0 
…m#903

* Replace the ResourceTest inheritance with WorkspaceTestRule
* Add @test annotations
* Remove unnecessary try-catch blocks
* Replace inheritance of utilities from WorkspaceTest with proper
in-place functionality
* Replace calls to deprecated API in StorageMergerTest

Contributes to
eclipse-platform#903
@HeikoKlare HeikoKlare marked this pull request as ready for review December 12, 2023 13:10
@HeikoKlare HeikoKlare mentioned this pull request Dec 12, 2023
Closed
@HeikoKlare
Copy link
Contributor Author

Maven warnings in Jenkins build are unrelated, see #969.

@HeikoKlare HeikoKlare merged commit a039b9c into eclipse-platform:master Dec 12, 2023
13 of 16 checks passed
@HeikoKlare HeikoKlare deleted the migrate-junit4-team.core branch December 12, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HeikoKlare