Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DPI awareness for chromium_subp to "System Aware" #42

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

pstuecker
Copy link
Contributor

By default Chromium enables the "PerMonitorV2" strategy for high DPI awareness. SWT instead defaults to "System" awareness as it does not yet support per monitor scaling (eclipse-platform/eclipse.platform.swt#131).

This leads to a mismatch in DPI settings between the Chromium render process (chromium_subp) and the host process (SWT application). If the browser widget is created on one monitor and then moved to another monitor, SWT does not rescale, but the Chromium render process does. This results in Chromium delivering a "too large" screen texture to SWT, which in turn results in strange visual artrifacts in the SWT application.

This PR forces chromium_subp to also use System Aware DPI scaling. If SWT supports PerMonitor scaling in the future, we'll have to adapt.

Copy link

License summary

❌ Not yet vetted dependencies:

Dependency License Status Ticket
-/-/-/chromium/113.0.5672.93 unknown restricted none
-/-/chromiumembedded/cef/113.1.5 unknown restricted none
  • Committers can request a license review via by commenting /request-license-review.
  • After all reviews have concluded, Committers can re-run the license-vetting check by commenting /license-check

Workflow run (with attached summary files):
https://github.com/eclipse-set/browser/actions/runs/6821292172

@PetersNils PetersNils self-requested a review November 13, 2023 13:43
@PetersNils PetersNils merged commit 5a80217 into main Nov 13, 2023
4 checks passed
@PetersNils PetersNils deleted the fix/highdpi branch November 13, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants