Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate watch script for browser and electron #178

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Add separate watch script for browser and electron #178

merged 1 commit into from
Jan 5, 2024

Conversation

JonasHelming
Copy link
Contributor

fixed #176

@JonasHelming JonasHelming marked this pull request as draft September 28, 2023 11:17
@JonasHelming @tortmayr
Add separate watch script for browser and electron
320ba2b 
fixed #176

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming JonasHelming marked this pull request as ready for review September 28, 2023 20:15
sdirix
sdirix approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! We should merge this as the watch for both apps at the same time does not make sense regarding their rebuilds.

@sdirix sdirix mentioned this pull request Jan 5, 2024
Closed
@JonasHelming JonasHelming merged commit 15b5b26 into master Jan 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

@vince-fugnitto vince-fugnitto Awaiting requested review from vince-fugnitto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watch breaks application start
2 participants
@JonasHelming @sdirix