Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: update license and headers #73

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Oct 21, 2020

Description

The commit includes the following updates which are prerequisites for
moving the repository under the eclipse foundation:

  • updates the repository license (license file and package.json
    entry).
  • updates the headers of source code,
  • includes the header snippet to easily add new licenses.

See here for motivation: motivation

See here for details: details

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@marcdumais-work
Copy link
Contributor

@vince-fugnitto the README still mentions Apache 2.0 license. You should probably use the same blurb we have in the main repo, that also covers the Theia trademark as well.

@marcdumais-work
Copy link
Contributor

I notice that the templates folder contains many source code files. Have you considered adding license headers for these too? If so, what made you decide against?

@vince-fugnitto
Copy link
Member Author

@marcdumais-work

@vince-fugnitto the README still mentions Apache 2.0 license. You should probably use the same blurb we have in the main repo, that also covers the Theia trademark as well.

Thank you! The readme has now been updated with a proper license and trademark.

I notice that the templates folder contains many source code files. Have you considered adding license headers for these too? If so, what made you decide against?

The templated are ultimately what the user will receive when they generate the extension, I did not want to add our headers to their generated extension.

@marcdumais-work
Copy link
Contributor

The templated are ultimately what the user will receive when they generate the extension, I did not want to add our headers to their generated extension.

I though it might be something like that. Makes sense I think, in this particular case.

@marcdumais-work
Copy link
Contributor

marcdumais-work commented Nov 2, 2020

Last thing I noticed: I think it would be good to give a bit of context in the commit message, about why this is being done.

e.g. mention the move of the repo to the Foundation: https://github.com/theia-ide/vscode-builtin-extensions/pull/36/commits

update: can you, as for vscode-builtin-extensions, include a link to the repo's wiki page about relicensing?

The commit includes the following updates which are prerequisites for
moving the repository under the eclipse foundation:

- updates the repository `license` (license file and `package.json`
  entry).
- updates the headers of source code,
- includes the header snippet to easily add new licenses.

See here for motivation: [motivation](#60)

See here for details:
[details](https://github.com/theia-ide/generator-theia-extension/wiki/Re-licensing-theia-ide-generator-theia-extension)

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto
Copy link
Member Author

Last thing I noticed: I think it would be good to give a bit of context in the commit message, about why this is being done.

Done!

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vince-fugnitto !

@JonasHelming
Copy link
Contributor

Thanks vince!

@marcdumais-work
Copy link
Contributor

I think the re-licensing exercise for this repo is all done! I have updated the wiki accordingly:
https://github.com/theia-ide/generator-theia-extension/wiki/Re-licensing-theia-ide-generator-theia-extension

I think we can merge this PR.

Thanks @JonasHelming and @vince-fugnitto

@marcdumais-work marcdumais-work merged commit 04081ed into master Nov 5, 2020
@marcdumais-work marcdumais-work deleted the vf/eclipse-header-updates branch November 5, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants