-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies to v1.12.1, add new Theia extensions #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (CI still pending)
Thanks for the update @dukengn . Among other things, this will make your new external terminal available in |
When can we expect a 1.12.0 build? |
I wonder if we should upgrade to v1.12.1 first before making a new build? |
@brianking I updated the PR to bump dependencies to v1.12.1 instead so we can benefit from the recent patch release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@marcdumais-work Done! Waiting for CI check again 👍 |
+ The following commit bumps dependencies to v1.12.1, following the release from Theia upstream repo. + `@theia/bulk-edit` is now explicit. + The commit also adds new Theia extensions: - `@theia/external-terminal` - `@theia/property-view` Signed-off-by: Duc Nguyen <duc.a.nguyen@ericsson.com>
All green now - merging. Thanks @dukengn! |
What it does
1.12.1
, following the release from Theia upstream repo.@theia/bulk-edit
is now explicit.@theia/external-terminal
@theia/property-view
How to test
Review checklist
Reminder for reviewers
Signed-off-by: Duc Nguyen duc.a.nguyen@ericsson.com