Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies to v1.12.1, add new Theia extensions #60

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

DucNgn
Copy link
Contributor

@DucNgn DucNgn commented Mar 29, 2021

What it does

  • The following commit bumps dependencies to 1.12.1, following the release from Theia upstream repo.
  • @theia/bulk-edit is now explicit.
  • The commit also adds new Theia extensions:
    • @theia/external-terminal
    • @theia/property-view

How to test

  • The app should be built/packaged successfully.

Review checklist

Reminder for reviewers

Signed-off-by: Duc Nguyen duc.a.nguyen@ericsson.com

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (CI still pending)

@marcdumais-work
Copy link
Contributor

Thanks for the update @dukengn . Among other things, this will make your new external terminal available in Blueprint!

@brianking
Copy link

When can we expect a 1.12.0 build?

@brianking
Copy link

I wonder if we should upgrade to v1.12.1 first before making a new build?
https://community.theia-ide.org/t/eclipse-theia-v1-12-1-patch-release/1588

@thegecko thegecko mentioned this pull request Mar 30, 2021
1 task
@DucNgn
Copy link
Contributor Author

DucNgn commented Mar 30, 2021

@brianking I updated the PR to bump dependencies to v1.12.1 instead so we can benefit from the recent patch release.

@DucNgn DucNgn changed the title Bump dependencies to v1.12.0, add new Theia extensions Bump dependencies to v1.12.1, add new Theia extensions Mar 30, 2021
Copy link
Member

@thegecko thegecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcdumais-work
Copy link
Contributor

@dukengn I suggest you rebase on this recent PR by @thegecko , that will likely clear the failing CI

@DucNgn
Copy link
Contributor Author

DucNgn commented Mar 31, 2021

@marcdumais-work Done! Waiting for CI check again 👍

+ The following commit bumps dependencies to v1.12.1, following
the release from Theia upstream repo.
+ `@theia/bulk-edit` is now explicit.
+ The commit also adds new Theia extensions:
	- `@theia/external-terminal`
	- `@theia/property-view`

Signed-off-by: Duc Nguyen <duc.a.nguyen@ericsson.com>
@marcdumais-work
Copy link
Contributor

All green now - merging. Thanks @dukengn!

@marcdumais-work marcdumais-work merged commit dc10587 into eclipse-theia:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants