Include task 'label' in the generated task.json

Issue: #8980 Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
eclipse-theia · Feb 2, 2021 · 0463885 · 0463885
1 parent 4db1cc8
commit 0463885
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/packages/plugin-ext/src/plugin/type-converters.ts b/packages/plugin-ext/src/plugin/type-converters.ts
@@ -721,12 +721,10 @@ export function fromTask(task: theia.Task): TaskDto | undefined {
     }
 
     const group = task.group;
-    if (group) {
-        if (group === TaskGroup.Build) {
-            taskDto.group = BUILD_GROUP;
-        } else if (group === TaskGroup.Test) {
-            taskDto.group = TEST_GROUP;
-        }
+    if (group === TaskGroup.Build) {
+        taskDto.group = BUILD_GROUP;
+    } else if (group === TaskGroup.Test) {
+        taskDto.group = TEST_GROUP;
     }
 
     const taskDefinition = task.definition;

diff --git a/packages/task/src/browser/task-configurations.ts b/packages/task/src/browser/task-configurations.ts
@@ -359,6 +359,9 @@ export class TaskConfigurations implements Disposable {
         if (task.group) {
             customization.group = task.group;
         }
+
+        customization.label = task.label;
+
         return { ...customization };
     }
 

diff --git a/packages/task/src/browser/task-service.ts b/packages/task/src/browser/task-service.ts
@@ -1105,6 +1105,7 @@ export class TaskService implements TaskConfigurationClient {
      * @param task The task to configure
      */
     async configure(token: number, task: TaskConfiguration): Promise<void> {
+        Object.assign(task, {label: this.taskNameResolver.resolve(task)});
         await this.taskConfigurations.configure(token, task);
     }