Skip to content

Commit

Permalink
[plugin] map dependencies to vscode builtins properly
Browse files Browse the repository at this point in the history
Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
  • Loading branch information
svenefftinge committed Sep 18, 2019
1 parent df1e55a commit 1029748
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions packages/plugin-ext-vscode/src/node/scanner-vscode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ export class VsCodePluginScanner extends TheiaPluginScanner implements PluginSca
}

getModel(plugin: PluginPackage): PluginModel {
// translate vscode builtins, as they are published with a prefix. See https://github.com/theia-ide/vscode-builtin-extensions/blob/master/src/republish.js#L50
const built_prefix = '@theia/vscode-builtin-';
if (plugin && plugin.name && plugin.name.startsWith(built_prefix)) {
plugin.name = plugin.name.substr(built_prefix.length);
}
const result: PluginModel = {
// see id definition: https://github.com/microsoft/vscode/blob/15916055fe0cb9411a5f36119b3b012458fe0a1d/src/vs/platform/extensions/common/extensions.ts#L167-L169
id: `${plugin.publisher.toLowerCase()}.${plugin.name.toLowerCase()}`,
Expand Down

0 comments on commit 1029748

Please sign in to comment.