[keybinding] Align 'Close Window' keybinding with VS Code across OSes

Signed-off-by: Jan Keromnes <jan.keromnes@typefox.io>
eclipse-theia · Nov 29, 2019 · 1805c55 · 1805c55
1 parent 5aac082
commit 1805c55
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/core/src/electron-browser/menu/electron-menu-contribution.ts b/packages/core/src/electron-browser/menu/electron-menu-contribution.ts
@@ -18,7 +18,7 @@ import * as electron from 'electron';
 import { inject, injectable } from 'inversify';
 import {
     Command, CommandContribution, CommandRegistry,
-    isOSX, MenuModelRegistry, MenuContribution, Disposable
+    isOSX, isWindows, MenuModelRegistry, MenuContribution, Disposable
 } from '../../common';
 import { KeybindingContribution, KeybindingRegistry } from '../../browser';
 import { FrontendApplication, FrontendApplicationContribution, CommonMenus } from '../../browser';
@@ -196,7 +196,7 @@ export class ElectronMenuContribution implements FrontendApplicationContribution
             },
             {
                 command: ElectronCommands.CLOSE_WINDOW.id,
-                keybinding: 'ctrlcmd+shift+w'
+                keybinding: (isOSX ? 'cmd+shift+w' : (isWindows ? 'ctrl+w' : /* Linux */ 'ctrl+q'))
             }
         );
     }