Fix: Plugins folders are created with exclamanation mark, which break…

…s webpack sign commit Signed-off-by: Shahar Harari <shahar.harari@sap.com> sign commit Signed-off-by: Shahar Harari <shahar.harari@sap.com>
eclipse-theia · May 14, 2020 · 252cae7 · 252cae7
1 parent 87c7705
commit 252cae7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/plugin-ext-vscode/src/node/plugin-vscode-file-handler.ts b/packages/plugin-ext-vscode/src/node/plugin-vscode-file-handler.ts
@@ -58,7 +58,7 @@ export class PluginVsCodeFileHandler implements PluginDeployerFileHandler {
         if (context.pluginEntry().type === PluginType.User) {
             extensionsDirUri = await this.environment.getExtensionsDirUri();
         }
-        return FileUri.fsPath(extensionsDirUri.resolve(filenamify(context.pluginEntry().id())));
+        return FileUri.fsPath(extensionsDirUri.resolve(filenamify(context.pluginEntry().id(), { replacement: '_' })));
     }
 
     protected async decompress(extensionDir: string, context: PluginDeployerFileHandlerContext): Promise<void> {

diff --git a/packages/plugin-ext/src/main/node/handlers/plugin-theia-file-handler.ts b/packages/plugin-ext/src/main/node/handlers/plugin-theia-file-handler.ts
@@ -53,6 +53,6 @@ export class PluginTheiaFileHandler implements PluginDeployerFileHandler {
         if (context.pluginEntry().type === PluginType.User) {
             pluginsDirUri = await this.environment.getPluginsDirUri();
         }
-        return FileUri.fsPath(pluginsDirUri.resolve(filenamify(context.pluginEntry().id())));
+        return FileUri.fsPath(pluginsDirUri.resolve(filenamify(context.pluginEntry().id(), { replacement: '_' })));
     }
 }