Addressing review comments (offline)

Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
eclipse-theia · May 12, 2023 · 26b2a6c · 26b2a6c
1 parent fbc47ca
commit 26b2a6c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,7 +5,7 @@
 - [Previous Changelogs](https://github.com/eclipse-theia/theia/tree/master/doc/changelogs/)
 
 
-## v1.38.0 -
+## v1.38.0 - 05/25/2023
 
 <a name="breaking_changes_1.38.0">[Breaking Changes:](#breaking_changes_1.38.0)</a>
 

diff --git a/packages/debug/src/common/debug-service.ts b/packages/debug/src/common/debug-service.ts
@@ -80,12 +80,12 @@ export interface DebugService extends Disposable {
     /**
      * @returns A Record of debug configuration provider types and a corresponding dynamic debug configurations array
      */
-    provideDynamicDebugConfigurations?(folder: string | undefined): Promise<Record<string, DebugConfiguration[]>>;
+    provideDynamicDebugConfigurations?(folder?: string): Promise<Record<string, DebugConfiguration[]>>;
 
     /**
      * Provides a dynamic debug configuration matching the name and the provider debug type
      */
-    fetchDynamicDebugConfiguration(name: string, type: string, folder: string | undefined): Promise<DebugConfiguration | undefined>;
+    fetchDynamicDebugConfiguration(name: string, type: string, folder?: string): Promise<DebugConfiguration | undefined>;
 
     /**
      * Resolves a [debug configuration](#DebugConfiguration) by filling in missing values

diff --git a/packages/debug/src/node/debug-service-impl.ts b/packages/debug/src/node/debug-service-impl.ts
@@ -71,7 +71,7 @@ export class DebugServiceImpl implements DebugService {
         // TODO: Support dynamic debug configurations through Theia extensions?
         return {};
     }
-    fetchDynamicDebugConfiguration(name: string, type: string, folder: string | undefined): Promise<DebugConfiguration | undefined> {
+    fetchDynamicDebugConfiguration(name: string, type: string, folder?: string): Promise<DebugConfiguration | undefined> {
         // TODO: Support dynamic debug configurations through Theia extensions?
         return Promise.resolve(undefined);
     }

diff --git a/packages/plugin-ext/src/main/browser/debug/plugin-debug-service.ts b/packages/plugin-ext/src/main/browser/debug/plugin-debug-service.ts
@@ -142,7 +142,7 @@ export class PluginDebugService implements DebugService {
         return results;
     }
 
-    async fetchDynamicDebugConfiguration(name: string, providerType: string, folder: string | undefined): Promise<DebugConfiguration | undefined> {
+    async fetchDynamicDebugConfiguration(name: string, providerType: string, folder?: string): Promise<DebugConfiguration | undefined> {
         const pluginProviders =
             Array.from(this.configurationProviders.values()).filter(p => (
                 p.triggerKind === DebugConfigurationProviderTriggerKind.Dynamic &&
@@ -160,7 +160,7 @@ export class PluginDebugService implements DebugService {
         }
     }
 
-    async provideDynamicDebugConfigurations(folder: string | undefined): Promise<Record<string, DebugConfiguration[]>> {
+    async provideDynamicDebugConfigurations(folder?: string): Promise<Record<string, DebugConfiguration[]>> {
         const pluginProviders =
             Array.from(this.configurationProviders.values()).filter(p => (
                 p.triggerKind === DebugConfigurationProviderTriggerKind.Dynamic &&