eslint: update ignorePatterns

The following commit updates the `ignorePatterns` to include `*.d.ts` files maintained by the project and exclude `lib` folders. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
eclipse-theia · Oct 14, 2020 · 3975e1f · 3975e1f
1 parent 0117651
commit 3975e1f
Show file tree

Hide file tree

Showing 15 changed files with 187 additions and 111 deletions.
diff --git a/configs/base.eslintrc.json b/configs/base.eslintrc.json
@@ -20,6 +20,6 @@
   },
   "ignorePatterns": [
     "node_modules",
-    "*.d.ts"
+    "lib"
   ]
-}
+}
diff --git a/packages/console/src/browser/monaco.d.ts b/packages/console/src/browser/monaco.d.ts
@@ -14,4 +14,5 @@
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
 
+// eslint-disable-next-line spaced-comment
 /// <reference types='@theia/monaco-editor-core/monaco'/>
diff --git a/packages/core/src/typings/native-keymap.d.ts b/packages/core/src/typings/native-keymap.d.ts
@@ -1,93 +1,108 @@
+/********************************************************************************
+ * Copyright (C) 2018 TypeFox and others.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v. 2.0 which is available at
+ * http://www.eclipse.org/legal/epl-2.0.
+ *
+ * This Source Code may also be made available under the following Secondary
+ * Licenses when the conditions for such availability set forth in the Eclipse
+ * Public License v. 2.0 are satisfied: GNU General Public License, version 2
+ * with the GNU Classpath Exception which is available at
+ * https://www.gnu.org/software/classpath/license.html.
+ *
+ * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
+ ********************************************************************************/
 /*---------------------------------------------------------------------------------------------
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
 declare module 'native-keymap' {
 
-	export interface IWindowsKeyMapping {
-		vkey: string;
-		value: string;
-		withShift: string;
-		withAltGr: string;
-		withShiftAltGr: string;
-	}
-	export interface IWindowsKeyboardMapping {
-		[code: string]: IWindowsKeyMapping;
-	}
-	export interface ILinuxKeyMapping {
-		value: string;
-		withShift: string;
-		withAltGr: string;
-		withShiftAltGr: string;
-	}
-	export interface ILinuxKeyboardMapping {
-		[code: string]: ILinuxKeyMapping;
-	}
-	export interface IMacKeyMapping {
-		value: string;
-		withShift: string;
-		withAltGr: string;
-		withShiftAltGr: string;
-		valueIsDeadKey: boolean;
-		withShiftIsDeadKey: boolean;
-		withAltGrIsDeadKey: boolean;
-		withShiftAltGrIsDeadKey: boolean;
-	}
-	export interface IMacKeyboardMapping {
-		[code: string]: IMacKeyMapping;
-	}
+    export interface IWindowsKeyMapping {
+        vkey: string;
+        value: string;
+        withShift: string;
+        withAltGr: string;
+        withShiftAltGr: string;
+    }
+    export interface IWindowsKeyboardMapping {
+        [code: string]: IWindowsKeyMapping;
+    }
+    export interface ILinuxKeyMapping {
+        value: string;
+        withShift: string;
+        withAltGr: string;
+        withShiftAltGr: string;
+    }
+    export interface ILinuxKeyboardMapping {
+        [code: string]: ILinuxKeyMapping;
+    }
+    export interface IMacKeyMapping {
+        value: string;
+        withShift: string;
+        withAltGr: string;
+        withShiftAltGr: string;
+        valueIsDeadKey: boolean;
+        withShiftIsDeadKey: boolean;
+        withAltGrIsDeadKey: boolean;
+        withShiftAltGrIsDeadKey: boolean;
+    }
+    export interface IMacKeyboardMapping {
+        [code: string]: IMacKeyMapping;
+    }
 
-	export type IKeyboardMapping = IWindowsKeyboardMapping | ILinuxKeyboardMapping | IMacKeyboardMapping;
+    export type IKeyboardMapping = IWindowsKeyboardMapping | ILinuxKeyboardMapping | IMacKeyboardMapping;
 
-	export function getKeyMap(): IKeyboardMapping;
+    export function getKeyMap(): IKeyboardMapping;
 
-	/* __GDPR__FRAGMENT__
-		"IKeyboardLayoutInfo" : {
-			"name" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
-			"id": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
-			"text": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
-		}
-	*/
-	export interface IWindowsKeyboardLayoutInfo {
-		name: string;
-		id: string;
-		text: string;
-	}
+    /* __GDPR__FRAGMENT__
+        "IKeyboardLayoutInfo" : {
+            "name" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
+            "id": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
+            "text": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
+        }
+    */
+    export interface IWindowsKeyboardLayoutInfo {
+        name: string;
+        id: string;
+        text: string;
+    }
 
-	/* __GDPR__FRAGMENT__
-		"IKeyboardLayoutInfo" : {
-			"model" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
-			"layout": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
-			"variant": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
-			"options": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
-			"rules": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
-		}
-	*/
-	export interface ILinuxKeyboardLayoutInfo {
-		model: string;
-		layout: string;
-		variant: string;
-		options: string;
-		rules: string;
-	}
+    /* __GDPR__FRAGMENT__
+        "IKeyboardLayoutInfo" : {
+            "model" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
+            "layout": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
+            "variant": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
+            "options": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
+            "rules": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
+        }
+    */
+    export interface ILinuxKeyboardLayoutInfo {
+        model: string;
+        layout: string;
+        variant: string;
+        options: string;
+        rules: string;
+    }
 
-	/* __GDPR__FRAGMENT__
-		"IKeyboardLayoutInfo" : {
-			"id" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
-			"lang": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
-		}
-	*/
-	export interface IMacKeyboardLayoutInfo {
-		id: string;
-		lang: string;
-	}
+    /* __GDPR__FRAGMENT__
+        "IKeyboardLayoutInfo" : {
+            "id" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
+            "lang": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
+        }
+    */
+    export interface IMacKeyboardLayoutInfo {
+        id: string;
+        lang: string;
+    }
 
-	export type IKeyboardLayoutInfo = IWindowsKeyboardLayoutInfo | ILinuxKeyboardLayoutInfo | IMacKeyboardLayoutInfo;
+    export type IKeyboardLayoutInfo = IWindowsKeyboardLayoutInfo | ILinuxKeyboardLayoutInfo | IMacKeyboardLayoutInfo;
 
-	export function getCurrentKeyboardLayout(): IKeyboardLayoutInfo;
+    export function getCurrentKeyboardLayout(): IKeyboardLayoutInfo;
 
-	export function onDidChangeKeyboardLayout(callback: () => void): void;
+    export function onDidChangeKeyboardLayout(callback: () => void): void;
 
-	export function isISOKeyboard(): boolean;
+    export function isISOKeyboard(): boolean;
 }
diff --git a/packages/debug/src/browser/monaco.d.ts b/packages/debug/src/browser/monaco.d.ts
@@ -14,4 +14,5 @@
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
 
+// eslint-disable-next-line spaced-comment
 /// <reference types='@theia/monaco/src/typings/monaco'/>
diff --git a/packages/filesystem/src/typings/dom.webkit.d.ts b/packages/filesystem/src/typings/dom.webkit.d.ts
@@ -14,6 +14,8 @@
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
 
+/* eslint-disable no-var */
+
 type WebKitEntriesCallback = ((entries: WebKitEntry[]) => void) | { handleEvent(entries: WebKitEntry[]): void; };
 
 type WebKitErrorCallback = ((err: DOMError) => void) | { handleEvent(err: DOMError): void; };

diff --git a/packages/filesystem/src/typings/mv/index.d.ts b/packages/filesystem/src/typings/mv/index.d.ts
@@ -16,6 +16,6 @@
 
 export = mv;
 declare module mv { }
+// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
 type MvOptions = { mkdirp?: boolean, clobber?: boolean, limit?: number };
 declare function mv(sourcePath: string, targetPath: string, options?: MvOptions, cb?: (error: NodeJS.ErrnoException) => void): void;
-
diff --git a/packages/filesystem/src/typings/nsfw/index.d.ts b/packages/filesystem/src/typings/nsfw/index.d.ts
@@ -13,4 +13,6 @@
  *
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
+
+// eslint-disable-next-line spaced-comment
 /// <reference types="@theia/core/src/typings/nsfw/index"/>
diff --git a/packages/git/src/browser/monaco.d.ts b/packages/git/src/browser/monaco.d.ts
@@ -14,4 +14,5 @@
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
 
+// eslint-disable-next-line spaced-comment
 /// <reference types='@theia/monaco/src/typings/monaco'/>
diff --git a/packages/keymaps/src/browser/monaco.d.ts b/packages/keymaps/src/browser/monaco.d.ts
@@ -1 +1,18 @@
-/// <reference types="@theia/monaco/src/typings/monaco/index"/>
+/********************************************************************************
+ * Copyright (C) 2018 TypeFox and others.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v. 2.0 which is available at
+ * http://www.eclipse.org/legal/epl-2.0.
+ *
+ * This Source Code may also be made available under the following Secondary
+ * Licenses when the conditions for such availability set forth in the Eclipse
+ * Public License v. 2.0 are satisfied: GNU General Public License, version 2
+ * with the GNU Classpath Exception which is available at
+ * https://www.gnu.org/software/classpath/license.html.
+ *
+ * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
+ ********************************************************************************/
+
+// eslint-disable-next-line spaced-comment
+/// <reference types="@theia/monaco/src/typings/monaco/index"/>
diff --git a/packages/monaco/src/typings/monaco/index.d.ts b/packages/monaco/src/typings/monaco/index.d.ts
@@ -15,6 +15,9 @@
  ********************************************************************************/
 
 /* eslint-disable @typescript-eslint/no-explicit-any */
+/* eslint-disable max-len */
+
+// eslint-disable-next-line spaced-comment
 /// <reference types='@theia/monaco-editor-core/monaco'/>
 
 declare module monaco.languages {
@@ -1496,7 +1499,7 @@ declare module monaco.error {
 
 declare module monaco.path {
     // https://github.com/microsoft/vscode/blob/320fbada86c113835aef4fb9d7c4bc5b74678166/src/vs/base/common/path.ts#L1494
-    export function normalize(path: string): string;
+    export function normalize(uriPath: string): string;
 }
 
 declare module monaco.wordHelper {

diff --git a/packages/plugin-ext/src/typings/monaco/index.d.ts b/packages/plugin-ext/src/typings/monaco/index.d.ts
@@ -14,6 +14,7 @@
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
 
+// eslint-disable-next-line spaced-comment
 /// <reference types='@theia/monaco/src/typings/monaco'/>
 
 /* expose internal APIs in @theia/monaco/src/typings/monaco */