Skip to content

Commit

Permalink
fix: remove bash login shell when run from task to align with vscode
Browse files Browse the repository at this point in the history
bash login shell (-l) causing different behavior compared to non login.
for example - it rebuilds the PATH environment and ignore what was defined in theia docker.

this change aligns with vscode that doesn't run with login shell.

Signed-off-by: Amiram Wingarten <amiram.wingarten@sap.com>
  • Loading branch information
amiramw authored and paul-marechal committed Dec 8, 2020
1 parent 385527f commit 4641a29
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- `{{uuid}}.mini-browser.{{hostname}}` by default.
- Can be configured via `THEIA_MINI_BROWSER_HOST_PATTERN` environment variable.
- Clients must setup this new hostname in their DNS resolvers.
- [task] remove bash login shell when run from task to align with vscode.

## v1.8.0 - 26/11/2020

Expand Down
2 changes: 1 addition & 1 deletion packages/task/src/node/process/process-task-runner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export class ProcessTaskRunner implements TaskRunner {

if (/bash(.exe)?$/.test(command)) {
quotingFunctions = BashQuotingFunctions;
execArgs = ['-l', '-c'];
execArgs = ['-c'];

} else if (/wsl(.exe)?$/.test(command)) {
quotingFunctions = BashQuotingFunctions;
Expand Down

0 comments on commit 4641a29

Please sign in to comment.