Skip to content

Commit

Permalink
Remove mini-browser dependency in plugin-ext
Browse files Browse the repository at this point in the history
Signed-off-by: Rob Moran <rob.moran@arm.com>
  • Loading branch information
thegecko committed Nov 26, 2019
1 parent 6f38e4f commit 4ae3cc4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion packages/plugin-ext/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"@theia/languages": "^0.12.0",
"@theia/markers": "^0.12.0",
"@theia/messages": "^0.12.0",
"@theia/mini-browser": "^0.12.0",
"@theia/monaco": "^0.12.0",
"@theia/navigator": "^0.12.0",
"@theia/output": "^0.12.0",
Expand Down
6 changes: 3 additions & 3 deletions packages/plugin-ext/src/main/browser/webview/webview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ import { injectable, inject, postConstruct } from 'inversify';
import { WebviewPanelOptions, WebviewPortMapping } from '@theia/plugin';
import { BaseWidget, Message } from '@theia/core/lib/browser/widgets/widget';
import { Disposable, DisposableCollection } from '@theia/core/lib/common/disposable';
// TODO: get rid of dependencies to the mini browser
import { MiniBrowserContentStyle } from '@theia/mini-browser/lib/browser/mini-browser-content-style';
import { ApplicationShellMouseTracker } from '@theia/core/lib/browser/shell/application-shell-mouse-tracker';
import { StatefulWidget } from '@theia/core/lib/browser/shell/shell-layout-restorer';
import { WebviewPanelViewState } from '../../../common/plugin-api-rpc';
Expand All @@ -49,6 +47,8 @@ import { WebviewResourceLoader } from '../../common/webview-protocol';
import { WebviewResourceCache } from './webview-resource-cache';
import { Endpoint } from '@theia/core/lib/browser/endpoint';

const TRANSPARENT_OVERLAY_STYLE = 'theia-mini-browser-transparent-overlay';

// tslint:disable:no-any

export const enum WebviewMessageChannels {
Expand Down Expand Up @@ -176,7 +176,7 @@ export class WebviewWidget extends BaseWidget implements StatefulWidget {
this.toDispose.push(this.onMessageEmitter);

this.transparentOverlay = document.createElement('div');
this.transparentOverlay.classList.add(MiniBrowserContentStyle.TRANSPARENT_OVERLAY);
this.transparentOverlay.classList.add(TRANSPARENT_OVERLAY_STYLE);
this.transparentOverlay.style.display = 'none';
this.node.appendChild(this.transparentOverlay);

Expand Down

0 comments on commit 4ae3cc4

Please sign in to comment.