GH-9150: Run SIW when updating the glob fields.

Closes #9150. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
eclipse-theia · Mar 12, 2021 · 52d460f · 52d460f
1 parent 45a008d
commit 52d460f
Showing 1 changed file with 20 additions and 3 deletions.
diff --git a/packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx b/packages/search-in-workspace/src/browser/search-in-workspace-widget.tsx
@@ -553,10 +553,27 @@ export class SearchInWorkspaceWidget extends BaseWidget implements StatefulWidge
                 id={kind + '-glob-field'}
                 onKeyUp={e => {
                     if (e.target) {
-                        if (Key.ENTER.keyCode === KeyCode.createKeyCode(e.nativeEvent).key?.keyCode) {
+                        const targetValue = (e.target as HTMLInputElement).value || '';
+                        let shouldSearch = Key.ENTER.keyCode === KeyCode.createKeyCode(e.nativeEvent).key?.keyCode;
+                        const currentOptions = (this.searchInWorkspaceOptions[kind] || []).slice().map(s => s.trim()).sort();
+                        const candidateOptions = this.splitOnComma(targetValue).map(s => s.trim()).sort();
+                        const sameAs = (left: string[], right: string[]) => {
+                            if (left.length !== right.length) {
+                                return false;
+                            }
+                            for (let i = 0; i < left.length; i++) {
+                                if (left[i] !== right[i]) {
+                                    return false;
+                                }
+                            }
+                            return true;
+                        };
+                        if (!sameAs(currentOptions, candidateOptions)) {
+                            this.searchInWorkspaceOptions[kind] = this.splitOnComma(targetValue);
+                            shouldSearch = true;
+                        }
+                        if (shouldSearch) {
                             this.resultTreeWidget.search(this.searchTerm, this.searchInWorkspaceOptions);
-                        } else {
-                            this.searchInWorkspaceOptions[kind] = this.splitOnComma((e.target as HTMLInputElement).value);
                         }
                     }
                 }}