Revert 'Activate widgets if opening them from navigator widget'

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
eclipse-theia · Dec 18, 2020 · 67cc0b8 · 67cc0b8
1 parent 21a1e97
commit 67cc0b8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -35,6 +35,7 @@
   - Used to filter incoming WebSocket connections: if `Origin` header does not match the list of hosts it will be refused.
   - Value is a comma-separated list of domain names including the port if not `80` nor `443`.
   - Example: `app.some.domain.com,app.other.domain:12345`.
+- [property-view] Added initial version of a selection-based property-view. A default implementation for file selections (via file navigator and default monaco editor).
 
 <a name="breaking_changes_1.8.1">[Breaking Changes:](#breaking_changes_1.8.1)</a>
 

diff --git a/packages/navigator/src/browser/navigator-model.ts b/packages/navigator/src/browser/navigator-model.ts
@@ -94,7 +94,7 @@ export class FileNavigatorModel extends FileTreeModel {
 
     previewNode(node: TreeNode): void {
         if (FileNode.is(node)) {
-            open(this.openerService, node.uri, { preview: true });
+            open(this.openerService, node.uri, { mode: 'reveal', preview: true });
         }
     }
 

diff --git a/packages/property-view/src/browser/property-view-widget.tsx b/packages/property-view/src/browser/property-view-widget.tsx
@@ -91,14 +91,6 @@ export class PropertyViewWidget extends BaseWidget {
         this.initializeContentWidget(this.selectionService.selection);
     }
 
-    protected onActivateRequest(msg: Message): void {
-        super.onActivateRequest(msg);
-        this.node.focus();
-        if (this.contentWidget) {
-            this.contentWidget.activate();
-        }
-    }
-
     protected onResize(msg: Widget.ResizeMessage): void {
         super.onResize(msg);
         if (this.contentWidget) {