Skip to content

Commit

Permalink
[core] remove virtual-widget and virtual-renderer
Browse files Browse the repository at this point in the history
Fixes #2300

Both the `virtual-widget` and `virtual-renderer` have been deprecated
since #2301. This patch cleans
up the codebase to remove the deprecated code as it should no longer be used/supported.

- removes the deprecated `virtual-widget`.
- removes the deprecated `virtual-renderer`.

One should instead opt to use `react-widget` and `react-renderer`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
  • Loading branch information
vince-fugnitto committed Jan 15, 2020
1 parent 3acbec2 commit 6c84259
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 152 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

Breaking changes:

- [core] removed `virtual-renderer`. `react-renderer` should be used instead [#6885](https://github.com/eclipse-theia/theia/pull/6885)
- [core] removed `virtual-widget`. `react-widget` should be used instead [#6885](https://github.com/eclipse-theia/theia/pull/6885)
- [task] renamed method `getStrigifiedTaskSchema()` has been renamed to `getStringifiedTaskSchema()` [#6780](https://github.com/eclipse-theia/theia/pull/6780)
- [task] renamed method `reorgnizeTasks()` has been renamed to `reorganizeTasks()` [#6780](https://github.com/eclipse-theia/theia/pull/6780)
- Support VS Code icon and color theming. [#6475](https://github.com/eclipse-theia/theia/pull/6475)
Expand Down Expand Up @@ -42,7 +44,7 @@ Breaking changes:
});
```
- or install from a VS Code extension.
- One should not introduce css color variables anymore or hardcode colors in css.
- One should not introduce css color variables anymore or hardcode colors in css.
- One can contribute new colors by implementing `ColorContribution` contribution point and calling `ColorRegistry.register`.
It's important that new colors are derived from existing VS Code colors if one plans to allow installation of VS Code extension contributing color themes.
Otherwise, there is no guarantee that new colors don't look alien for a random VS Code color theme.
Expand Down
2 changes: 0 additions & 2 deletions packages/core/src/browser/widgets/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,5 @@
********************************************************************************/

export * from './widget';
export * from './virtual-renderer';
export * from './virtual-widget';
export * from './react-renderer';
export * from './react-widget';
89 changes: 0 additions & 89 deletions packages/core/src/browser/widgets/virtual-renderer.ts

This file was deleted.

60 changes: 0 additions & 60 deletions packages/core/src/browser/widgets/virtual-widget.ts

This file was deleted.

0 comments on commit 6c84259

Please sign in to comment.