No infinite loop for path lookups

eclipse-theia · Jul 5, 2022 · 74696f0 · 74696f0
1 parent c869edb
commit 74696f0
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/core/src/common/menu/menu-model-registry.ts b/packages/core/src/common/menu/menu-model-registry.ts
@@ -272,12 +272,14 @@ export class MenuModelRegistry {
      */
     getPath(node: MenuNode): MenuPath | undefined {
         const identifiers = [];
+        const visited: MenuNode[] = [];
         let next: MenuNode | undefined = node;
 
-        while (next) {
+        while (next && !visited.includes(next)) {
             if (next === this.root) {
                 return identifiers.reverse();
             }
+            visited.push(next);
             identifiers.push(next.id);
             next = next.parent;
         }