Minor PR comments

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
eclipse-theia · Jan 19, 2023 · 89a1b45 · 89a1b45
1 parent 0deb955
commit 89a1b45
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/core/src/browser/shell/application-shell.ts b/packages/core/src/browser/shell/application-shell.ts
@@ -521,7 +521,7 @@ export class ApplicationShell extends Widget {
                     uris.forEach(openUri);
                 } else if (event.dataTransfer.files?.length > 0) {
                     // the files were dragged from the outside the workspace
-                    Array.from(event.dataTransfer.files).forEach(async file => {
+                    Array.from(event.dataTransfer.files).forEach(file => {
                         if (file.path) {
                             const fileUri = URI.fromComponents({
                                 scheme: 'file',

diff --git a/packages/filesystem/src/browser/file-tree/file-tree-widget.tsx b/packages/filesystem/src/browser/file-tree/file-tree-widget.tsx
@@ -128,7 +128,7 @@ export class FileTreeWidget extends CompressedTreeWidget {
                 selectedNodes = [node];
             }
             this.setSelectedTreeNodesAsData(event.dataTransfer, node, selectedNodes);
-            const uris = selectedNodes.filter(n => FileStatNode.is(n)).map(n => (n as FileStatNode).fileStat.resource);
+            const uris = selectedNodes.filter(FileStatNode.is).map(n => n.fileStat.resource);
             if (uris.length > 0) {
                 ApplicationShell.setDraggedEditorUris(event.dataTransfer, uris);
             }

diff --git a/packages/plugin-ext/src/plugin/tree/tree-views.ts b/packages/plugin-ext/src/plugin/tree/tree-views.ts
@@ -196,7 +196,7 @@ class TreeViewExtImpl<T> implements Disposable {
     private readonly nodes = new Map<string, TreeExtNode<T>>();
     private pendingRefresh = Promise.resolve();
 
-    private localDataTransfer: DataTransfer = new DataTransfer();
+    private localDataTransfer = new DataTransfer();
 
     private readonly toDispose = new DisposableCollection(
         Disposable.create(() => this.clearAll()),