[keybinding] Make "⌘," the default keybinding to "Open Preferences" o…

…n Mac OS (except in Firefox)
eclipse-theia · Nov 25, 2019 · 950473d · 950473d
1 parent 145f913
commit 950473d
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/packages/preferences/src/browser/preferences-contribution.ts b/packages/preferences/src/browser/preferences-contribution.ts
@@ -29,6 +29,8 @@ import { FileSystem } from '@theia/filesystem/lib/common';
 import { UserStorageService } from '@theia/userstorage/lib/browser';
 import { PreferencesContainer } from './preferences-tree-widget';
 import { EditorManager } from '@theia/editor/lib/browser';
+import { isFirefox } from '@theia/core/lib/browser';
+import { isOSX } from '@theia/core/lib/common/os';
 
 @injectable()
 export class PreferencesContribution extends AbstractViewContribution<PreferencesContainer> {
@@ -61,6 +63,12 @@ export class PreferencesContribution extends AbstractViewContribution<Preference
     }
 
     registerKeybindings(keybindings: KeybindingRegistry): void {
+        if (isOSX && !isFirefox) {
+            keybindings.registerKeybinding({
+                command: CommonCommands.OPEN_PREFERENCES.id,
+                keybinding: 'cmd+,'
+            });
+        }
         keybindings.registerKeybinding({
             command: CommonCommands.OPEN_PREFERENCES.id,
             keybinding: 'ctrl+,'