fix editors theme change and widget not attached error (#13757)

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
eclipse-theia · Jun 4, 2024 · a6fb882 · a6fb882
1 parent 4456fde
commit a6fb882
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/packages/monaco/src/browser/monaco-standalone-theme-service.ts b/packages/monaco/src/browser/monaco-standalone-theme-service.ts
@@ -41,6 +41,7 @@ export class MonacoStandaloneThemeService extends StandaloneThemeService {
                 for (let i = 0; i < this.styleElements.length; i++) {
                     if (this.styleElements[i] === style) {
                         this.styleElements.splice(i, 1);
+                        style.remove();
                         return;
                     }
                 }

diff --git a/packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx b/packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx
@@ -187,6 +187,7 @@ export class CellOutputWebviewImpl implements CellOutputWebview, Disposable {
         }
 
         this.webviewWidget = await this.widgetManager.getOrCreateWidget(WebviewWidget.FACTORY_ID, { id: this.id });
+        this.webviewWidget.parent = this.editor ?? null;
         this.webviewWidget.setContentOptions({
             allowScripts: true,
             // eslint-disable-next-line max-len