Skip to content

Commit

Permalink
Prevent task terminal title from being changed by task process (#13003)
Browse files Browse the repository at this point in the history
Don't use server title for task terminals, instead use the provided
widget title

Signed-off-by: Bryan Chen <Bryan.Chen2@microchip.com>
  • Loading branch information
bryanchenmchp authored Nov 10, 2023
1 parent 882e125 commit a88d39e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

- [Previous Changelogs](https://github.com/eclipse-theia/theia/tree/master/doc/changelogs/)

## v1.44.0
- [task] prevent task widget title from being changed by task process [#13003](https://github.com/eclipse-theia/theia/pull/13003)

## v1.43.0 - 10/26/2023

- [application-manager] fixed backend webpack output and watching [#12902](https://github.com/eclipse-theia/theia/pull/12902)
Expand Down
3 changes: 2 additions & 1 deletion packages/task/src/browser/task-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1092,7 +1092,8 @@ export class TaskService implements TaskConfigurationClient {
title: taskInfo
? `Task: ${taskInfo.config.label}`
: `Task: #${taskId}`,
destroyTermOnClose: true
destroyTermOnClose: true,
useServerTitle: false
}, {
widgetOptions: { area: 'bottom' },
mode: widgetOpenMode,
Expand Down

0 comments on commit a88d39e

Please sign in to comment.