Skip to content

Commit

Permalink
repo: drop support for node 10
Browse files Browse the repository at this point in the history
the following commit drops `node v10` support from the framework:
- updates the `engines` tag.
- updates any documentation related to node version.
- updates the CI to drop `node 10` builds.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
  • Loading branch information
vince-fugnitto committed Aug 21, 2020
1 parent 9d2dcd0 commit b10fec5
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 17 deletions.
15 changes: 4 additions & 11 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,34 +116,27 @@ jobs:
fast_finish: true
include:
- stage: test
name: Ubuntu / Node 10 / Python 2
name: Ubuntu / Python 2
os: linux
dist: xenial
node_js: 10
- stage: test
name: Ubuntu / Node 12 / Python 2
os: linux
dist: xenial
- stage: test
name: Ubuntu / Node 12 / Python 3 (No Tests!)
name: Ubuntu / Python 3 (No Tests)
os: linux
dist: xenial
env:
- PYTHON=/usr/bin/python3
before_script:
- node --version
- $PYTHON --version
# no tests, just build
script: yarn
- name: macOS / Node 12 / Python 2
- name: macOS / Python 2
os: osx
osx_image: xcode11.4
env: CXX=c++
script:
- travis_retry yarn test:theia
- name: Windows / Node 10 / Python 2
- name: Windows / Python 2
os: windows
node_js: 10
env:
- CXX=c++
- YARN_GPG=no
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@
},
```
- Consequently, `ThemeService` and `IconThemeService` don't allow to change the default color or icon theme anymore.
<a name="1_5_0_drop_node_10_support"></a>
- [[repo]](#1_5_0_drop_node_10_support) support for `Node 10` is dropped. [#8290](https://github.com/eclipse-theia/theia/pull/8290)
- From now on, Node.js `12.x` is required when building.\
The recommended minimum version is aligned with `electron` (Node.js `12.14.1`).

## v1.4.0 - 30/07/2020

Expand Down
8 changes: 3 additions & 5 deletions doc/Developing.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,8 @@ For Windows instructions [click here](#building-on-windows).

## Prerequisites

- Node.js `>= 10.11.0` **AND** `< 12.x`.
- Preferably, **use** version `10.15.3`, it has the [active LTS](https://github.com/nodejs/Release).
- Node.js `11.x` is untested.
- Node.js `12.x` is [unsupported](https://github.com/eclipse-theia/theia/issues/5117).
- Node.js `>= 12.14.1` **AND** `< 13`.
- Preferably, **use** Node version [`12.14.1`](https://nodejs.org/download/release/v12.14.1/), as it is the the recommended minimum version according to the framework's supported `electron` version.
- [Yarn package manager](https://yarnpkg.com/en/docs/install) v1.7.0
- git (If you would like to use the Git-extension too, you will need to have git version 2.11.0 or higher.)

Expand Down Expand Up @@ -327,7 +325,7 @@ etc.) by opening `packages/<package name>/coverage/index.html`.

- Install [`scoop`](https://github.com/lukesampson/scoop#installation).
- Install [`nvm`](https://github.com/coreybutler/nvm-windows) with scoop: `scoop install nvm`.
- Install Node.js with `nvm`: `nvm install 10.15.3`, then use it: `nvm use 10.15.3`. You can list all available Node.js versions with `nvm list available` if you want to pick another version.
- Install Node.js with `nvm`: `nvm install 12.14.1`, then use it: `nvm use 12.14.1`. You can list all available Node.js versions with `nvm list available` if you want to pick another version.
- Install `yarn`: `scoop install yarn`.
- Install [`windows-build-tools`](https://github.com/felixrieseberg/windows-build-tools). Run `PowerShell` as _Administrator_ and copy paste the following: `npm --add-python-to-path install --global --production windows-build-tools`

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"version": "0.0.0",
"engines": {
"yarn": "1.0.x || >=1.2.1",
"node": ">=10.11.0 <13"
"node": ">=12.14.1 <13"
},
"resolutions": {
"**/@types/node": "~10.3.6",
Expand Down

0 comments on commit b10fec5

Please sign in to comment.