Skip to content

Commit

Permalink
Always set exact version when publishing
Browse files Browse the repository at this point in the history
Theia is using "^1.x.y" in all modules, this causes two problems
1) Since romantic versioning is used within Theia repo, API
   breakage might be introduced between any version

2) It's harder to build applications using old versions of Theia
   extensions since if not every needed Theia extension is explicitly
   stated in dependencies you will likely end up with pulling several
   parallel versions of @theia/core for example. Due to dependency
   injection we can not have multiple parallel versions of the same
   Theia extension module

Fixes issue #8879 when publishing next version

Contributed by STMicroelectronics

Signed-off-by: Niklas DAHLQUIST <niklas.dahlquist@st.com>
Signed-off-by: Samuel HULTGREN <samuel.hultgren@st.com>
  • Loading branch information
Niklas-Dahlquist committed Jan 13, 2021
1 parent db4b2e7 commit bbb8f05
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Change Log

## v1.10.0

<a name="breaking_changes_1.10.0">[Breaking Changes:](#breaking_changes_1.10.0)</a>

- [dependencies] updated to use fixed versions when publishing, `"x.y.z"` instead of `"^x.y.z"` in dependencies [#8880](https://github.com/eclipse-theia/theia/pull/8880)

## v1.9.0 - 16/12/2020

- [cli] updated error reporting for the `download-plugins` script [#8798](https://github.com/eclipse-theia/theia/pull/8798)
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"rebuild:electron": "theia rebuild:electron",
"rebuild:electron:debug": "DEBUG=electron-rebuild && yarn rebuild:electron",
"publish": "yarn && yarn test && yarn publish:latest",
"publish:latest": "lerna publish && yarn publish:check",
"publish:latest": "lerna publish --exact && yarn publish:check",
"publish:next": "yarn next:publish && yarn next:publish --skip-npm && yarn publish:check",
"next:publish": "lerna publish --exact --canary=next --npm-tag=next --yes",
"publish:check": "node scripts/check-publish.js",
Expand Down

0 comments on commit bbb8f05

Please sign in to comment.