DiffNavigator should not be Disposable, as it's managed by diff editor.

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
eclipse-theia · Feb 22, 2018 · da62d1c · da62d1c
1 parent da65869
commit da62d1c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/packages/editor/src/browser/diff-navigator.ts b/packages/editor/src/browser/diff-navigator.ts
@@ -6,9 +6,8 @@
  */
 
 import { TextEditor } from './editor';
-import { Disposable } from '@theia/core/lib/common';
 
-export interface DiffNavigator extends Disposable {
+export interface DiffNavigator {
     revealFirst: boolean;
     canNavigate(): boolean;
     hasNext(): boolean;

diff --git a/packages/monaco/src/browser/monaco-diff-nagivator-factory.ts b/packages/monaco/src/browser/monaco-diff-nagivator-factory.ts
@@ -21,7 +21,6 @@ export class MonacoDiffNavigatorFactory {
         next: () => { },
         previous: () => { },
         revealFirst: false,
-        dispose: () => { },
     };
 
     createdDiffNavigator(editor: IStandaloneDiffEditor, options?: IDiffNavigatorOptions): DiffNavigator {
@@ -44,7 +43,6 @@ export class MonacoDiffNavigatorFactory {
             next: () => navigator.next(),
             previous: () => navigator.previous(),
             revealFirst: navigator.revealFirst,
-            dispose: () => navigator.dispose(),
         };
     }
 }