Skip to content

Commit

Permalink
Add missing git diff caption
Browse files Browse the repository at this point in the history
Fixes #4639

Currently, the `git-diff-widget` does not have a caption (tooltip).
This means that when the widget is docked, and it's icon is displayed,
no tooltip is shown when hovering while others widget do include it.
For the sake of completeness and consistency, the `git-diff-widget`
should include a caption.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
  • Loading branch information
vince-fugnitto committed Mar 21, 2019
1 parent 6a07cec commit e38fd2a
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion packages/git/src/browser/diff/git-diff-widget.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ export const GIT_DIFF = 'git-diff';
@injectable()
export class GitDiffWidget extends GitNavigableListWidget<GitFileChangeNode> implements StatefulWidget {

protected readonly GIT_DIFF_TITLE = 'Diff';

protected fileChangeNodes: GitFileChangeNode[] = [];
protected options: Git.Options.Diff;

Expand All @@ -48,7 +50,9 @@ export class GitDiffWidget extends GitNavigableListWidget<GitFileChangeNode> imp
super();
this.id = GIT_DIFF;
this.scrollContainer = 'git-diff-list-container';
this.title.label = 'Diff';
this.title.label = this.GIT_DIFF_TITLE;
this.title.caption = this.GIT_DIFF_TITLE;

this.title.iconClass = 'theia-git-diff-icon';

this.addClass('theia-git');
Expand Down

0 comments on commit e38fd2a

Please sign in to comment.