Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
  • Loading branch information
ndoschek committed Jan 17, 2021
1 parent b61fda5 commit e8b2279
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## v1.10.0

- [plugin] added `createDeployQuickOpenItem` method to create `DeployQuickOpenItem` in order to make extension deploy command extensible [#8919] (https://github.com/eclipse-theia/theia/pull/8919)
- [property-view] Added initial version of a selection-based property-view. A default implementation is available for file selections (via file navigator and default monaco editor).

## v1.9.0 - 16/12/2020

Expand Down Expand Up @@ -39,7 +40,6 @@
- Used to filter incoming WebSocket connections: if `Origin` header does not match the list of hosts it will be refused.
- Value is a comma-separated list of domain names including the port if not `80` nor `443`.
- Example: `app.some.domain.com,app.other.domain:12345`.
- [property-view] Added initial version of a selection-based property-view. A default implementation for file selections (via file navigator and default monaco editor).

<a name="breaking_changes_1.8.1">[Breaking Changes:](#breaking_changes_1.8.1)</a>

Expand Down
8 changes: 8 additions & 0 deletions packages/property-view/src/browser/property-view-widget.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ export class PropertyViewWidget extends BaseWidget {
this.initializeContentWidget(this.selectionService.selection);
}

protected onActivateRequest(msg: Message): void {
super.onActivateRequest(msg);
this.node.focus();
if (this.contentWidget) {
this.contentWidget.activate();
}
}

protected onResize(msg: Widget.ResizeMessage): void {
super.onResize(msg);
if (this.contentWidget) {
Expand Down

0 comments on commit e8b2279

Please sign in to comment.